Date: Thu, 8 Feb 2001 18:30:08 -0800 (PST) From: Tony Finch <dot@dotat.at> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/24962: properly delay acks in half-closed TCP connections Message-ID: <200102090230.f192U8n59062@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/24962; it has been noted by GNATS.
From: Tony Finch <dot@dotat.at>
To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG, Tony Finch <dot@dotat.at>
Subject: Re: kern/24962: properly delay acks in half-closed TCP connections
Date: Fri, 9 Feb 2001 02:23:54 +0000
Garrett Wollman <wollman@khavrinen.lcs.mit.edu> wrote:
><<On Fri, 09 Feb 2001 01:28:36 +0000, Tony Finch <dot@dotat.at> said:
>
>> + (tp)->t_state >= TCPS_ESTABLISHED) { \
>
>Should use the appropriate macro rather than assuming a particular
>ordering on the TCP states. In this case, TCPS_HAVEESTABLISHED(state).
I noticed later that NetBSD and OpenBSD have both inlined that macro
at the single place it is invoked.
Tony.
--
f.a.n.finch fanf@covalent.net dot@dotat.at
MALIN HEBRIDES BAILEY: VARIABLE BECOMING SOUTHEASTERLY 3 OR 4, INCREASING 6 OR
7, OCCASIONALLY GALE 8 IN BAILEY LATER. RAIN LATER. GOOD BECOMING MODERATE.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200102090230.f192U8n59062>