Date: Tue, 10 Dec 2024 15:50:02 -0700 From: Warner Losh <imp@bsdimp.com> To: Ed Maste <emaste@freebsd.org> Cc: "Bjoern A. Zeeb" <bz@freebsd.org>, Jessica Clarke <jrtc27@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 87e140a5c6f8 - main - iwlwifi: avoid (hard) hang on loading module Message-ID: <CANCZdfpC-HX2XFonp%2BbYKJP5why7kYy6r%2Bb1HDRa7ja6bBdktQ@mail.gmail.com> In-Reply-To: <CAPyFy2CHFH5SF3=YNZLA2iUOA2z9Kugn5Xx4xagDrt4jnz2a5g@mail.gmail.com> References: <202412091447.4B9ElFBH050286@gitrepo.freebsd.org> <6F9C2C43-A3DD-4CF5-AC27-899FE139E9A6@freebsd.org> <0883q825-802q-2n9q-3s4o-3nq13qpqno71@SerrOFQ.bet> <CAPyFy2CHFH5SF3=YNZLA2iUOA2z9Kugn5Xx4xagDrt4jnz2a5g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Dec 10, 2024, 3:09 PM Ed Maste <emaste@freebsd.org> wrote: > On Mon, 9 Dec 2024 at 20:55, Bjoern A. Zeeb <bz@freebsd.org> wrote: > > > > On Mon, 9 Dec 2024, Jessica Clarke wrote: > > > > > On 9 Dec 2024, at 14:47, Bjoern A. Zeeb <bz@FreeBSD.org> wrote: > > >> > > >> The branch main has been updated by bz: > > >> > > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=87e140a5c6f89eea7ea6320d1ae34566492abfc0 > > >> + if (bootverbose) > > >> + printf("%s: module '%s' not yet available; will be" > > >> + "initialized in a moment\n", __func__, op->name); > > > > > > Missing a space in the string. > > > > Thanks; I'll add that. > > Or just allow the line to go beyond 80 columns, allowing someone to > grep for "will be initialized in a moment" to find the source of this > string. > It's either in style.9 as a length exception or is in a review somewhere... it make it easier to grep the error messages... Warner > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Dec 10, 2024, 3:09 PM Ed Maste <<a href="mailto:emaste@freebsd.org">emaste@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, 9 Dec 2024 at 20:55, Bjoern A. Zeeb <<a href="mailto:bz@freebsd.org" target="_blank" rel="noreferrer">bz@freebsd.org</a>> wrote:<br> ><br> > On Mon, 9 Dec 2024, Jessica Clarke wrote:<br> ><br> > > On 9 Dec 2024, at 14:47, Bjoern A. Zeeb <bz@FreeBSD.org> wrote:<br> > >><br> > >> The branch main has been updated by bz:<br> > >><br> > >> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=87e140a5c6f89eea7ea6320d1ae34566492abfc0" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=87e140a5c6f89eea7ea6320d1ae34566492abfc0</a><br>; > >> + if (bootverbose)<br> > >> + printf("%s: module '%s' not yet available; will be"<br> > >> + "initialized in a moment\n", __func__, op->name);<br> > ><br> > > Missing a space in the string.<br> ><br> > Thanks; I'll add that.<br> <br> Or just allow the line to go beyond 80 columns, allowing someone to<br> grep for "will be initialized in a moment" to find the source of this<br> string.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">It's either in style.9 as a length exception or is in a review somewhere... it make it easier to grep the error messages...</div><div dir="auto"><br></div><div dir="auto">Warner </div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpC-HX2XFonp%2BbYKJP5why7kYy6r%2Bb1HDRa7ja6bBdktQ>