Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Feb 2014 15:11:20 -0500
From:      "Adam Weinberger" <adamw@adamw.org>
To:        "Tijl Coosemans" <tijl@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org
Subject:   Re: svn commit: r346570 - head/mail/squirrelmail
Message-ID:  <E30C30A6-ED8C-489F-AD49-7B06D260BAD8@adamw.org>
In-Reply-To: <20140228205412.17dead83@kalimero.tijl.coosemans.org>
References:  <201402281928.s1SJSOFd043779@svn.freebsd.org> <20140228205412.17dead83@kalimero.tijl.coosemans.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 28 Feb 2014, at 14:54, Tijl Coosemans wrote:

> On Fri, 28 Feb 2014 19:28:24 +0000 (UTC) Adam Weinberger wrote:
>> 	${CHMOD} 730 ${STAGEDIR}${SQUIRRELDIR}/attach
>> 	${CHMOD} 750 ${STAGEDIR}${SQUIRRELDIR}/data
>
> I think you can remove the chmod commands too...
>
>
>> Modified: head/mail/squirrelmail/pkg-plist
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- head/mail/squirrelmail/pkg-plist	Fri Feb 28 19:14:42 =

>> 2014	(r346569)
>> +++ head/mail/squirrelmail/pkg-plist	Fri Feb 28 19:28:23 =

>> 2014	(r346570)
>> @@ -1,5 +1,7 @@
>> etc/periodic/daily/111.clean-squirrelmail
>> %%SQUIRRELDIR%%/attach/.htaccess
>> +@exec chown %%SMUSER%%:%%SMGROUP%% %B
>> +@exec chmod 730 %B
>
> ...if you do this as follows:
>
> @owner %%SMUSER%%
> @group %%SMGROUP%%
> @mode 730
> %%SQUIRRELDIR%%/attach/.htaccess
> @owner
> @group
> @mode
>
> Are you sure that 3 for group permissions is correct?
>
>> +@exec chown %%SMUSER%%:%%SMGROUP%% %B
>> +@exec chmod 750 %B
>
> Same here, but you could also group it with the .htaccess file above.
>
> The pkg-plist format is explained in the pkg-create manpage by the =

> way.

%B refers to the dirname. Your suggestion would change the ownership and =

permissions of the .htaccess file, which would then require an @exec =

chown and @exec chmod to repair, so it wouldn't really fix anything.

# Adam


--
Adam Weinberger
adamw@adamw.org
http://www.adamw.org





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E30C30A6-ED8C-489F-AD49-7B06D260BAD8>