Date: Wed, 28 Sep 2016 11:55:47 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Jan Henrik Sylvester <me@janh.de> Cc: FreeBSD-USB Mailing List <freebsd-usb@freebsd.org>, John Baldwin <jhb@freebsd.org> Subject: Re: Status of PCIe Hotplug? Message-ID: <b192f906-7e2e-339c-675c-5d6a01e6b7cd@selasky.org> In-Reply-To: <3c6ab189-aad0-2593-1d3c-f221de294174@janh.de> References: <D7E110DB-EF6D-41DD-8D69-A021422916FA@sarenet.es> <791ee95b-ab4e-f07e-6b8d-0e0b6c49ceb0@janh.de> <E9D08BBA-762D-4F27-A853-645764235209@sarenet.es> <58f84457-d775-3023-5727-a326bc8df722@FreeBSD.org> <a5c570cf-28ff-dc70-cb2b-67d91adf0c56@janh.de> <05657098-a8dd-9d0d-ea75-4c3fdc582795@selasky.org> <3c6ab189-aad0-2593-1d3c-f221de294174@janh.de>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 09/28/16 11:31, Jan Henrik Sylvester wrote:
> On 09/28/2016 10:32, Hans Petter Selasky wrote:
>> Can you compile your kernel with debugging enabled so that we get the
>> sourcelines in the dump below. Also please include some parts of the
>
> The kernel is from the yet-to-be-released 11.0-RELEASE installed by
> freebsd-update. Now I have extracted kernel-dbg.txz, base-dbg.txz, and
> lib32-dbg.txz from the 11.0-RELEAESE distribution, but the backtrace
> still looks similar. Do have have to do anything else to use the debug
> symbols or do I really have to compile a new kernel?
>
Hi,
Can you try the attached patch. Does it make any difference?
device_delete_child() will delete devices starting at the leaves, while
USB expects parents to be detached first.
jhb: Any comments?
--HPS
[-- Attachment #2 --]
Index: sys/dev/pci/pci_pci.c
===================================================================
--- sys/dev/pci/pci_pci.c (revision 306255)
+++ sys/dev/pci/pci_pci.c (working copy)
@@ -1217,7 +1217,8 @@
}
} else {
if (sc->child != NULL) {
- if (device_delete_child(dev, sc->child) == 0)
+ if (device_detach(sc->child) == 0 &&
+ device_delete_child(dev, sc->child) == 0)
sc->child = NULL;
}
}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b192f906-7e2e-339c-675c-5d6a01e6b7cd>