Date: Sat, 28 Dec 2013 18:45:11 -0800 From: Marcel Moolenaar <marcel@xcllnt.net> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar <marcel@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r259908 - head/sys/vm Message-ID: <14556BDB-35C3-49CE-896A-DEA8B1EB5B9C@xcllnt.net> In-Reply-To: <52BF6699.1040006@freebsd.org> References: <201312260546.rBQ5kAoJ009798@svn.freebsd.org> <52BF6699.1040006@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_74A7F0B3-FBE7-45BE-9813-536FAE1F82CC Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Dec 28, 2013, at 4:02 PM, Nathan Whitehorn <nwhitehorn@freebsd.org> wrote: > On 12/26/13 00:46, Marcel Moolenaar wrote: >> Author: marcel >> Date: Thu Dec 26 05:46:10 2013 >> New Revision: 259908 >> URL: http://svnweb.freebsd.org/changeset/base/259908 >> >> Log: >> For ia64, use pmap_remove_pages() and not pmap_remove(). The problem is >> that we don't have a good way (yet) to iterate over the mapped pages by >> virtual address and simply try each page within the range. Given that we >> call pmap_remove() over the entire 2^63 bytes of address space, it takes >> a while for pmap_remove to have tried all 2^50 pages. >> By using pmap_remove_pages() we use the PV list to find all mappings. >> >> Change derived from a patch by: alc >> > > Why make this ia64-specific? It seems like a potentially useful general > optimization and certainly shouldn't be harmful on other architectures. What alc@ said. Making it generic requires a bit more work and it's not clear to me whether it's a good change. Basically, ia64 fails to handle the pmap_remove() interface. So, for now I see it as a quick fix. What happens next is open. We're thinking of using the new trie code to track PTEs per PMAP. This helps to support pmap_remove() efficiently and may have other advantages. -- Marcel Moolenaar marcel@xcllnt.net --Apple-Mail=_74A7F0B3-FBE7-45BE-9813-536FAE1F82CC Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlK/jLcACgkQpgWlLWHuifZwCACeKGw0BUH3uRFlN1ovJyHIwQdX MK0AmwZsBLfjxyaAaxKxRU75Jrmf6LCc =qidu -----END PGP SIGNATURE----- --Apple-Mail=_74A7F0B3-FBE7-45BE-9813-536FAE1F82CC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14556BDB-35C3-49CE-896A-DEA8B1EB5B9C>