Date: Fri, 6 Mar 2026 21:57:56 +0100 From: Daniel Engberg <diizzy@FreeBSD.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 8bd89ab595cb - main - deskutils/qownnotes: the port had been updated to version 26.3.3 Message-ID: <43507d39-02d0-4a4f-9d21-ea3eb1905f07@FreeBSD.org> In-Reply-To: <c2qstoxqvf24uhlruyhxfeq3rda2c5hnjsam5exvydkpfyeyee@lmjkjrmrznfh> References: <69aa7cc7.1e357.86a2325@gitrepo.freebsd.org> <d9c764b0-d7ac-42b6-b7dc-749f78c34cdd@FreeBSD.org> <c2qstoxqvf24uhlruyhxfeq3rda2c5hnjsam5exvydkpfyeyee@lmjkjrmrznfh>
index | next in thread | previous in thread | raw e-mail
On 2026-03-06 21:40, Mathieu Arnold wrote: > On Fri, Mar 06, 2026 at 05:50:56PM +0100, Daniel Engberg wrote: >> On 2026-03-06 08:05, Alexey Dokuchaev wrote: >>> The branch main has been updated by danfe: >>> >>> URL: https://cgit.FreeBSD.org/ports/commit/?id=8bd89ab595cb9f03ab29068b1a0c08795d438781 >>> >>> commit 8bd89ab595cb9f03ab29068b1a0c08795d438781 >>> Author: Alexey Dokuchaev <danfe@FreeBSD.org> >>> AuthorDate: 2026-03-06 07:04:40 +0000 >>> Commit: Alexey Dokuchaev <danfe@FreeBSD.org> >>> CommitDate: 2026-03-06 07:04:40 +0000 >>> >>> deskutils/qownnotes: the port had been updated to version 26.3.3 >>> Reduce vertical space to help Makefile maintainability by merging >>> sporadic use of helpers and two per-flavor conditionals into one; >>> drop needless default flavor assignment. >> You've now introduced more regressions (check portlint) and review >> https://docs.freebsd.org/en/books/porters-handbook/book/#flavors-using . >> Please fix your commit or back it out. > > I'd like to address this calmly but clearly: the ports tree does not > have a single maintainer enforcing a unified style, and that's by > design. Committers are free to make reasonable stylistic choices within > their own ports, provided the result is correct and maintainable. > > Helpers exist to assist. Their use is encouraged but not mandatory. In > some cases, explicit constructs are simply more readable, and that is a > legitimate trade-off that other contributors are entitled to make. > > We would all appreciate it if this could be discussed as peers rather > than as a rule-setter and a rule-follower. Alexey already addressed the > concerns about a specific pattern that you had. Ultimately, style > decisions belong to the maintainer of each port, not to third-party > reviewers. > ...and if you're is not the maintainer and the process for timeout and taking over maintainership have been bypassed numerous of times by looking at commit log? Best regards, Danielhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43507d39-02d0-4a4f-9d21-ea3eb1905f07>