Date: Tue, 4 Mar 2008 13:15:42 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Roman Divacky <rdivacky@freebsd.org> Cc: current@freebsd.org Subject: Re: shared lock instead of exclusive in set_rootvnode Message-ID: <20080304111542.GA57756@deviant.kiev.zoral.com.ua> In-Reply-To: <20080303200946.GA79061@freebsd.org> References: <20080303200946.GA79061@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Mar 03, 2008 at 09:09:46PM +0100, Roman Divacky wrote: > hi > > in set_rootvnode() there is > > p->p_fd->fd_cdir = rootvnode; > p->p_fd->fd_rdir = rootvnode; > > protected just by FILEDESC_SLOCK(), I dont think this is correct > although it might be benign as this is used only during boot. > > still, if it's not correct it should be fixed > > comments? Seems right. Did you boot with patched kernel ? [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEARECAAYFAkfNL10ACgkQC3+MBN1Mb4iP6ACgu5DsrsOnvFOTxFh+6PS6ywlG YuUAn0qBUwzlf13ur9sfs9k99ONVJgQg =AK9V -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080304111542.GA57756>