Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Jun 2022 17:04:29 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 034667f9fa16 - main - dtrace: add warning for /dev/dtrace/prototype
Message-ID:  <202206011704.251H4T5Y052948@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=034667f9fa16be785b53c1367c08c51d56d07e0f

commit 034667f9fa16be785b53c1367c08c51d56d07e0f
Author:     Christos Margiolis <christos@FreeBSD.org>
AuthorDate: 2022-06-01 16:58:31 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2022-06-01 16:58:31 +0000

    dtrace: add warning for /dev/dtrace/prototype
    
    Let the programmer know that creating a device is not necessary.
    
    Reviewed by:    markj
    Differential Revision:  https://reviews.freebsd.org/D35381
---
 sys/cddl/dev/prototype.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/sys/cddl/dev/prototype.c b/sys/cddl/dev/prototype.c
index 6e31f19d5ce6..bcbb3d202b27 100644
--- a/sys/cddl/dev/prototype.c
+++ b/sys/cddl/dev/prototype.c
@@ -82,7 +82,10 @@ prototype_disable(void *arg, dtrace_id_t id, void *parg)
 static void
 prototype_load(void *dummy)
 {
-	/* Create the /dev/dtrace/prototype entry. */
+	/*
+	 * Create the /dev/dtrace/prototype entry.
+	 * XXX: Remove this if the provider does not need any customs ioctls.
+	 */
 	prototype_cdev = make_dev(&prototype_cdevsw, 0, UID_ROOT, GID_WHEEL, 0600,
 	    "dtrace/prototype");
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202206011704.251H4T5Y052948>