Date: Thu, 13 Nov 2014 12:39:40 -0500 From: Eric van Gyzen <eric@vangyzen.net> To: FreeBSD current <freebsd-current@freebsd.org>, kib@freebsd.org Subject: [patch] Wrong assertion in kern_umtx.c Message-ID: <5464ECDC.1080002@vangyzen.net>
next in thread | raw e-mail | index | archive | help
There is a [practically] tautological assertion in kern_umtx.c. I have
not even compile-tested the following patch. I'll test it when I have
time. I'd be grateful if someone beats me to it.
Eric
diff --git a/sys/kern/kern_umtx.c b/sys/kern/kern_umtx.c
index 33fdf71..c6b42c0 100644
--- a/sys/kern/kern_umtx.c
+++ b/sys/kern/kern_umtx.c
@@ -169,7 +169,7 @@ struct umtxq_chain {
};
#define UMTXQ_LOCKED_ASSERT(uc)
mtx_assert(&(uc)->uc_lock, MA_OWNED)
-#define UMTXQ_BUSY_ASSERT(uc) KASSERT(&(uc)->uc_busy, ("umtx
chain is not busy"))
+#define UMTXQ_BUSY_ASSERT(uc) KASSERT((uc)->uc_busy, ("umtx
chain is not busy"))
/*
* Don't propagate time-sharing priority, there is a security reason,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5464ECDC.1080002>