Date: Wed, 28 Dec 2011 16:40:49 +0100 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@spoerlein.net> To: Doug Barton <dougb@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Xin LI <delphij@FreeBSD.org> Subject: Re: svn commit: r228896 - head/contrib/netcat Message-ID: <20111228154049.GD83814@acme.spoerlein.net> In-Reply-To: <4EF83AF4.9010108@FreeBSD.org> References: <201112260907.pBQ979X4098221@svn.freebsd.org> <4EF83AF4.9010108@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On Mon, 2011-12-26 at 01:14:28 -0800, Doug Barton wrote: > On 12/26/2011 01:07, Xin LI wrote: > > Author: delphij > > Date: Mon Dec 26 09:07:08 2011 > > New Revision: 228896 > > URL: http://svn.freebsd.org/changeset/base/228896 > > > > Log: > > Merge from OpenBSD 5.0 (this is a dummy change, the vendor change does not > > apply to us). > > When I'm importing stat(1) stuff from Net/OpenBSD I don't do this. I > will however comment in the commit log for the next substantive change, > "Skipped update N.NN because the change was not relevant to us," or > words to that effect. > > I'm not suggesting that my way of doing this is perfect, or cannot be > improved. I would suggest however that this change was needless churn. I think it was the right thing to do. It's better to have one person (Xin LI) figure out if the change is needed or a no-op and do the upgrade to match our version to upstream's version, than to have a discrepancy between the two and cause half a dozen developers that stumble upon that difference to scratch their heads and spend time in figuring out if we should import the change. Cheers, Ulihome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111228154049.GD83814>