Date: Tue, 28 Jul 2020 11:14:18 -0400 From: Mark Johnston <markj@freebsd.org> To: Eric van Gyzen <eric@vangyzen.net> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r363607 - head/sys/vm Message-ID: <20200728151418.GE59953@raichu> In-Reply-To: <aaeec727-c2ac-c5fb-3bee-b4c1bb1bcd64@vangyzen.net> References: <202007271425.06REPBtv075771@repo.freebsd.org> <aaeec727-c2ac-c5fb-3bee-b4c1bb1bcd64@vangyzen.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 28, 2020 at 08:44:11AM -0500, Eric van Gyzen wrote: > On 7/27/20 9:25 AM, Mark Johnston wrote: > > + > > + /* > > + * We may be attempting to free the page as part of the handling for an > > + * I/O error, in which case the page was xbusied by a different thread. > > + */ > > + vm_page_xbusy_claim(m); > > I've just noticed that vm_page_xbusy_claim() ignores the WAITERS bit. > Is this not a problem in practice? Thanks, I think you're right. I posted a proposed patch here: https://reviews.freebsd.org/D25859
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200728151418.GE59953>