Date: Thu, 13 Aug 2015 16:43:47 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Baptiste Daroussin <bapt@freebsd.org> Cc: Bruce Evans <brde@optusnet.com.au>, Bruce Simpson <bms@fastmail.net>, Davide Italiano <davide@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, svn-src-projects@freebsd.org Subject: Re: svn commit: r286484 - projects/collation/usr.bin/localedef Message-ID: <20150813162711.U1840@besplex.bde.org> In-Reply-To: <20150813061802.GA62875@ivaldir.etoilebsd.net> References: <201508082257.t78MvIT1000841@repo.freebsd.org> <CACYV=-GnOpPddd-x_J0yW4g4QFsdcEVXaVc9CER9JD7iObGzAg@mail.gmail.com> <20150812182739.GB51754@ivaldir.etoilebsd.net> <55CB91FD.8000004@fastmail.net> <20150813114425.X996@besplex.bde.org> <20150813061802.GA62875@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 13 Aug 2015, Baptiste Daroussin wrote:
> On Thu, Aug 13, 2015 at 12:16:41PM +1000, Bruce Evans wrote:
>> On Wed, 12 Aug 2015, Bruce Simpson wrote:
>>>>> ...
>>>>> Can you commit this one to HEAD && move it to the right header?
>>
>> This has too many bugs to commit.
>
> FYI the version proposed for tree(3):
>
> #define RB_COUNT(x, name, head, cnt) do { \
> (cnt) = 0; \
> RB_FOREACH((x), name, (head)) { \
> (cnt)++; \
> } \
> } while (0)
Now it is bug for bug consistent with tree.h in using a space instead of
a tab after #define (tree.h is inconsistent with itself for only 5 out
of 82 #define's).
It doesn't line up the backslashe the same. tree.h consistently lines
them up in column 72 whenever possible.
It adds 1 more inconsistency for the do-while(0) hack. tree.h uses
/*CONSTCOND*/ lint markup for 10 of 11 instances. This is too ugly
for me, but it is the existing style.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150813162711.U1840>