Date: Fri, 15 Jul 2016 23:22:30 +0800 From: "Euan Thoms" <euan@potensol.com> To: koobs@FreeBSD.org Cc: =?utf-8?q?Martin_Waschb=C3=BCsch?= <martin@waschbuesch.de>, "Walter Schwarzenfeld" <w.schwarzenfeld@utanet.at>, freebsd-ports@freebsd.org Subject: =?utf-8?q?Re=3A?==?utf-8?q?_devel=2Fsope=3A?= make =?utf-8?q?=28stage-qa=29?= now fails with =?utf-8?q?DEVELOPER=3Dyes?= complaining about iconv dependency Message-ID: <7c8e-5788ff80-3-6b8b4580@96884534> In-Reply-To: <a9c1c4ab-b040-5412-1570-b2ae9f34723a@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, July 15, 2016 15:26 SGT, Kubilay Kocak <koobs@FreeBSD.org> w= rote: > On 15/07/2016 5:17 PM, Martin Waschb=C3=BCsch wrote: > > > >> Am 14.07.2016 um 23:29 schrieb Euan Thoms <euan@potensol.com>: > >> > >> > >> On Friday, July 15, 2016 01:11 SGT, Walter Schwarzenfeld > >> <w.schwarzenfeld@utanet.at> wrote: > >> > >>> I think this statements should be only warnings. Cause not all > >>> of these statements are right and each maintianer should decide > >>> which "USES" or "LIB=5FDEPENDS" are necessairely and which not. > >> > >> Well, I don't know enough to comment about whether it should be > >> classed as a warning or an error. But there's definetely a bug in = > >> the ports Mk system, since adding USES+=3Diconv does not remove th= e > >> error. I don't think I even need iconv as a dependency, it should = > >> be included lower down in the dependency tree. > > > > I am not sure about this. At the very least, sope-core does use ico= nv > > in its NGExtensions (e.g. NSString+Encoding.m). Can we really assum= e > > some lower dependency package already pulls iconv in? > > If something in a port links to libiconv (or anything else), then > the dependency should be registered in that port > OK, thanks guys. I will add libiconv as a LIB=5FDEPENDS. But I still th= ink there may be a bug. The make error tells me to use USES+=3Diconv an= d it doesn't work, I still get the same error about libiconv not being = specified as a dependancy. -- Regards, Euan Thoms
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7c8e-5788ff80-3-6b8b4580>