Date: Sun, 3 May 2026 12:26:26 -0300 From: Jose Luis Duran <jlduran@freebsd.org> To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 5a6d9479ae22 - main - blocklistd: Fix RFC1918 typo Message-ID: <CAPwQLcfU_c-n0G=K9dMf%2BVCQwK0u8uS%2BDFj05VEF32uYMxiZXQ@mail.gmail.com> In-Reply-To: <86lde0wsdz.fsf@ltc.des.dev> References: <69f6de20.3297c.4f1f048a@gitrepo.freebsd.org> <86lde0wsdz.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
On Sun, May 3, 2026 at 10:10 AM Dag-Erling Smørgrav <des@freebsd.org> wrote: > > Jose Luis Duran <jlduran@FreeBSD.org> writes: > > commit 5a6d9479ae2271a97dd23ceee8ad284770302874 > > Author: Jose Luis Duran <jlduran@FreeBSD.org> > > AuthorDate: 2026-05-03 05:31:51 +0000 > > Commit: Jose Luis Duran <jlduran@FreeBSD.org> > > CommitDate: 2026-05-03 05:31:51 +0000 > > > > blocklistd: Fix RFC1918 typo > > > > The address in the configuration file example was intended to be from > > the 192.168.0.0/16 range of IPv4 private addresses (RFC1918). > > I'm sure it was but we should be using RFC 5737 addresses instead. At > least the IPv6 examples are correct... Yesterday, when I was pushing this patch I realized that we should indeed be using documentation-specific addresses for blocklistd.conf(5), instead of using IPs from Level 3 and APNIC. I'll submit a patch upstream based on your suggestion. Thanks! > > Reported on mastodon.social at > > https://mastodon.social/@asmodai/116316630762241486. > > that's asmodai@freebsd.org Reported by: asmodai > > > > Fix submitted upstream by emaste@. Fixing locally first. > > > > Reviewed by: emaste > > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D56773 > > DES > -- > Dag-Erling Smørgrav - des@FreeBSD.org -- Jose Luis Duranhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPwQLcfU_c-n0G=K9dMf%2BVCQwK0u8uS%2BDFj05VEF32uYMxiZXQ>