Date: Tue, 24 Dec 2002 00:50:06 -0800 (PST) From: Tom Rhodes <trhodes@FreeBSD.org> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/46501: Ping exits 2 when it should exit 1 Message-ID: <200212240850.gBO8o6XO034596@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/46501; it has been noted by GNATS. From: Tom Rhodes <trhodes@FreeBSD.org> To: Maxim Konovalov <maxim@FreeBSD.org> Cc: spam-pr@silverwraith.com, bug-followup@FreeBSD.org Subject: Re: bin/46501: Ping exits 2 when it should exit 1 Date: Tue, 24 Dec 2002 03:47:25 -0500 On Tue, 24 Dec 2002 11:41:01 +0300 (MSK) Maxim Konovalov <maxim@FreeBSD.org> wrote: > On 23:30-0800, Dec 23, 2002, Avleen Vig wrote: > > > > Exit is already documented as 2, like the code. > > > This has been 2 for a long time now, why do you want to change it > > > all of a sudden? In my opinion this change isn't correct because > > > so many other utilities are using exit(2); also. > > > > Ping is documented as I stated in ping(8) as exiting 1 when it > > actually exits 2. > > From ping(8): > > RETURN VALUES > The ping utility returns an exit status of zero if at least one > response was heard from the specified host; a status of two if > the transmission > ----------------------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > ^^^^^^ > was successful but no responses were received; or another value > (from<sysexits.h>) if an error occurred. > > > I don't know of any other utils that exit(2) when they don't have > > somthing exiting 1 already. src/sbin/fsck src/sbin/mountd src/sbin/routed src/sbin/tunefs src/bin/sh src/sbin/savecore src/usr.sbin/usbd src/usr.sbin/fdcontrol src/usr.sbin/lpd all use exit(2); This seems common. > > It makes little sense to exit(2) when there's nothing in ping that > > will exit(1). > > > > Thus it makes sense to correct this. I don't believe "it haven't > > been changed for a long time" is a valid reason for leaving > > something broken/incorrect. > > > > If this won't be fixed, then the documentation needs to be fixed, > > but I don't feel that's correct. > > -- > Maxim Konovalov, maxim@FreeBSD.org > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200212240850.gBO8o6XO034596>