Date: Tue, 3 Feb 2026 09:56:12 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Abdelkader Boudih <freebsd@seuros.com> Subject: Re: git: 052a791b0055 - main - acpi: add Darwin OSI quirk for Apple Mac hardware Message-ID: <aYGqHESSZPxYL9QZ@kib.kiev.ua> In-Reply-To: <0A69735E-8BF6-41B1-AB7A-9B761A0FF158@gmail.com> References: <698154c0.35e9d.2d7b8775@gitrepo.freebsd.org> <aYGIvC3v0zQCJrGo@kib.kiev.ua> <0A69735E-8BF6-41B1-AB7A-9B761A0FF158@gmail.com>
index | next in thread | previous in thread | raw e-mail
On Mon, Feb 02, 2026 at 10:41:58PM -0800, Enji Cooper (yaneurabeya) wrote:
>
> > On Feb 2, 2026, at 9:33 PM, Konstantin Belousov <kostikbel@gmail.com> wrote:
>
> ...
>
> >> + if (ACPI_SUCCESS(status)) {
> >> + device_printf(dev,
> >> + "Apple hardware: installed Darwin "
> >> + "OSI and removed other vendor OSI "
> >> + "(Windows, etc)\n");
> > Why this verbosity is needed?
> >
> > I see no benefit from it, other then consuming kernel memory.
>
> I added the verbosity. It helped a few of us Apple users determine whether or not the functionality was working. I can trim down the verbosity if needed in a followup commit.
Yes, I think that this verbosity is not warranted. If you want something
to be printed, much shorter messages would be enough. But I am not sure
that any messaging is needed.
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aYGqHESSZPxYL9QZ>