Date: Mon, 30 Dec 2019 18:37:47 -0800 From: Conrad Meyer <cem@freebsd.org> To: Rick Macklem <rmacklem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r356210 - head/sys/nfs Message-ID: <CAG6CVpXrE5eCzQQ7UzfaADwBdxbk2h4m83HF6gAKxERmaLz8RA@mail.gmail.com> In-Reply-To: <201912302239.xBUMdTli021436@repo.freebsd.org> References: <201912302239.xBUMdTli021436@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Rick,
One suggestion:
On Mon, Dec 30, 2019 at 2:39 PM Rick Macklem <rmacklem@freebsd.org> wrote:
>
> Author: rmacklem
> Date: Mon Dec 30 22:39:29 2019
> New Revision: 356210
> ...
> --- head/sys/nfs/nfs_lock.c Mon Dec 30 22:05:57 2019 (r356209)
> +++ head/sys/nfs/nfs_lock.c Mon Dec 30 22:39:29 2019 (r356210)
> @@ -89,6 +89,8 @@ nfslock_open(struct cdev *dev, int oflags, int devtype
> {
> int error;
>
> + printf("WARNING: uses Giant and will be removed before FreeBSD 13\n"
> + "\tuse the kernel NFSLOCKD/nfslockd.ko\n");
This could be 'gone_in(13, "uses Giant; replace with NFSLOCKD/nfslockd.ko");'
Best,
Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpXrE5eCzQQ7UzfaADwBdxbk2h4m83HF6gAKxERmaLz8RA>