Date: Mon, 29 Mar 2021 10:26:58 -0700 From: Adrian Chadd <adrian@freebsd.org> To: qcwap <1051244836@qq.com>, freebsd-wireless <freebsd-wireless@freebsd.org> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: Correct net80211 channel flag. Message-ID: <CAJ-Vmon8yS5D0Q6QdCNLC9VWoKG_tuP_HLrLGzNJjhNWhXLXNA@mail.gmail.com> In-Reply-To: <tencent_2D16BB0B925A1EA4B4BAD2454A8C4F503F06@qq.com> References: <tencent_2D16BB0B925A1EA4B4BAD2454A8C4F503F06@qq.com>
next in thread | previous in thread | raw e-mail | index | archive | help
hm!
On Mon, 29 Mar 2021 at 08:02, qcwap <1051244836@qq.com> wrote:
>
> This patch corrects ieee80211_vht_get_vhtcap_ie for 160/80P80 channel width recognition.
>
> diff --git a/sys/net80211/ieee80211.h b/sys/net80211/ieee80211.h
> index 86ab1459cca..76c43629b33 100644
> --- a/sys/net80211/ieee80211.h
> +++ b/sys/net80211/ieee80211.h
> @@ -811,9 +811,9 @@ struct ieee80211_ie_vht_operation {
> #define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_MASK 0x0000000C
> #define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_MASK_S 2
> #define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_NONE 0
> -#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_160MHZ 1
> -#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_160_80P80MHZ 2
> -#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_RESERVED 3
> +#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_160MHZ 4
> +#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_160_80P80MHZ 8
> +#define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_RESERVED 16
>
> #define IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_IS_160MHZ(_vhtcaps) \
> (_IEEE80211_MASKSHIFT(_vhtcaps, IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_MASK) >= \
This is the flag change from the draft 11ac spec to the released 11ac
spec, right?
I remember they needed to change the flags because existing draft
implementations got the 80+80/160MHz negotiation really badly wrong in
some interop places...
-adrian
>
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmon8yS5D0Q6QdCNLC9VWoKG_tuP_HLrLGzNJjhNWhXLXNA>