Date: Tue, 08 Apr 2003 17:48:44 +0200 From: Dag-Erling Smorgrav <des@ofug.org> To: www@freebsd.org Subject: Change default mode for query-pr-summary Message-ID: <xzpznn1m1lv.fsf@flood.ping.uio.no>
next in thread | raw e-mail | index | archive | help
--=-=-=
The current default behaviour for query-pr-summary is to group PRs by
severity. This is meaningless as originators often set an inflated
severity on their PRs, and handlers rarely change it. The attached
patch changes the default to just show all PRs, without removing the
option to group them by severity.
DES
--
Dag-Erling Smorgrav - des@ofug.org
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=query-pr-summary.diff
Index: en/cgi/query-pr-summary.cgi
===================================================================
RCS file: /home/dcvs/www/en/cgi/query-pr-summary.cgi,v
retrieving revision 1.39
diff -u -r1.39 query-pr-summary.cgi
--- en/cgi/query-pr-summary.cgi 6 Mar 2003 23:51:58 -0000 1.39
+++ en/cgi/query-pr-summary.cgi 8 Apr 2003 15:47:27 -0000
@@ -150,9 +150,9 @@
# If someone does a multiple-variable query they will probably do weird things.
$self_ref1 = $self_ref . '?';
-$self_ref1 .= 'sort=' . escape($input{'sort'}) if $input{'sort'};
-print '<P>You may view summaries by <A HREF="', $self_ref1, '">Severity</A>, ';
-$self_ref1 .= '&' if ($self_ref1 !~/\?$/);
+$self_ref1 .= 'sort=' . escape($input{'sort'}) . "&" if $input{'sort'};
+print '<P>You may view summaries by ';
+print '<A HREF="', $self_ref1, 'severity=summary">Severity</A>, ';
print '<A HREF="', $self_ref1, 'state=summary">State</A>, ';
print '<A HREF="', $self_ref1, 'category=summary">Category</A>, or ';
print '<A HREF="', $self_ref1, 'responsible=summary">Responsible Party</A>.';
@@ -252,7 +252,7 @@
} elsif ($input{'category'} eq 'summary') {
&cat_summary;
-} elsif ($input{'severity'} eq '') {
+} elsif ($input{'severity'} eq 'summary') {
&severity_summary;
} else {
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpznn1m1lv.fsf>