Date: Tue, 16 Aug 2005 20:39:30 +0000 (UTC) From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/my if_my.c if_myreg.h Message-ID: <200508162039.j7GKdUSP019966@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jhb 2005-08-16 20:39:30 UTC
FreeBSD src repository
Modified files:
sys/dev/my if_my.c if_myreg.h
Log:
Fixup locking in if_my(4) and mark it MPSAFE:
- Add locked variants of my_start() and my_init().
- Assert that the lock is held in several places rather than recursing.
- Overhaul failure case handling in my_attach() so that it will actually
clean up completely in each of the failure cases.
- Setup the interrupt after ether_ifattach() in my_attach().
- Remove unused callout handle from softc.
- Free the metadata for the descriptors my_in detach() (we leaked it
before).
- Fix locking in my_ioctl().
- Remove spls.
Tested by: brueffer
MFC after: 3 days
Revision Changes Path
1.34 +95 -103 src/sys/dev/my/if_my.c
1.5 +1 -1 src/sys/dev/my/if_myreg.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200508162039.j7GKdUSP019966>