Date: 29 Mar 2014 04:48:18 -0000 From: Larry Baird <lab@maxwell.gta.com> To: freebsd-stable@freebsd.org Cc: Dimitry Andric <dim@FreeBSD.org> Subject: Re: HEADS UP: merged llvm/clang 3.4 Message-ID: <20140329044818.84350.qmail@mailgate.gta.com> In-Reply-To: <AE8439D0-637D-45DA-8DD1-37888266FD44@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>> > I understand that installing gdb from ports, changing compiler
>> > flags from -g to -gdwarf-2 in Makefiles, or switching to compiling
>> > with gcc are all reasonable workarounds, but this seems a bit like
>> > POLA for a stable branch.
>>
>> Yeah, it is really unpleasant.
>>
>> Maybe we should do something like this for stable/9 and stable/10
>> branches (not tested).
>>
>> --- contrib/llvm/tools/clang/lib/Driver/Tools.cpp
>> +++ contrib/llvm/tools/clang/lib/Driver/Tools.cpp
>> @@ -2628,8 +2628,9 @@ void Clang::ConstructJob(Compilation &C, const Job
>> CmdArgs.push_back("-gdwarf-4");
>> else if (!A->getOption().matches(options::OPT_g0) &&
>> !A->getOption().matches(options::OPT_ggdb0)) {
>> - // Default is dwarf-2 for darwin.
>> - if (getToolChain().getTriple().isOSDarwin())
>> + // Default is dwarf-2 for Darwin and FreeBSD.
>> + if (getToolChain().getTriple().isOSDarwin() ||
>> + getToolChain().getTriple().getOS() == llvm::Triple::FreeBSD)
>> CmdArgs.push_back("-gdwarf-2");
>> else
>> CmdArgs.push_back("-g");
>
> I'm now testing something similar, which also tests the FreeBSD version,
> so it can be applied to head and then MFC'd. I will commit it soon.
Glad to hear. Adding an extra flag, to get applications to a state where
they could be debugged was unexpected. I am sure I wouldn't have been the
only one surprised to find out that "cc -g" no longer works.
Larry
--
------------------------------------------------------------------------
Larry Baird
Global Technology Associates, Inc. 1992-2012 | http://www.gta.com
Celebrating Twenty Years of Software Innovation | Orlando, FL
Email: lab@gta.com | TEL 407-380-0220
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140329044818.84350.qmail>