Date: Sat, 31 Jul 2021 23:39:45 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 257522] msdosfs rename(2) deadlock Message-ID: <bug-257522-227-VpbRoCahYK@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-257522-227@https.bugs.freebsd.org/bugzilla/> References: <bug-257522-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257522 Konstantin Belousov <kib@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kib@FreeBSD.org --- Comment #1 from Konstantin Belousov <kib@FreeBSD.org> --- msdosfs_rename() has the same issue as was present in ufs_rename() long time ago. First, relookup() cannot be used while any vnode is locked. Instead, speci= al non-sleeping variant of msdosfs_lookup() needs to be made available and app= lied there. It is already coded (dd_ino !=3D NULL for msdosfs_lookup_() I belie= ve), just needs to be exposed and applied. Another issue is that function prologue must not use sleepable vn_lock() when owning any other vnode lock. Mostly, it needs to mimic the structure of ufs_rename() for acquiring all three or four locks. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-257522-227-VpbRoCahYK>