Date: Thu, 29 Nov 2001 23:39:43 -0800 From: Jordan Hubbard <jkh@winston.freebsd.org> To: Makoto Matsushita <matusita@jp.freebsd.org> Cc: current@FreeBSD.org Subject: Re: PATCH: sysinstall to remove userconfig code Message-ID: <9456.1007105983@winston.freebsd.org> In-Reply-To: Message from Makoto Matsushita <matusita@jp.freebsd.org> of "Fri, 30 Nov 2001 14:19:14 %2B0900." <20011130141914A.matusita@jp.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> BTW, how dou you think my other patch (use 'devfs' while mounting > filesystems, use fsck_ffs instead of fsck) for sysinstall, which was > posted about a week before to current@FreeBSD.org? You can fetch from: > > <URL:http://people.freebsd.org/~matusita/5.0-CURRENT-20011121-JPSNAP_usedevfs /patch> Hmmm. To be honest, at least one part doesn't make too much sense to me. In the quoted section, where you move up the code for copying the initial /dev files from the mfsroot to the new on-disk root, you then proceed to mount a devfs instance right over it. Don't you want to try the devfs mount and only copy device files if that returns an error code? You're just going to do extra work and then cover it up otherwise. :-) + + dialog_clear_norefresh(); + msgNotify("Copying initial device files.."); + /* Copy the boot floppy's dev files */ + if ((root->newfs || upgrade) && vsystem("find -x /dev | cpio %s -pdum /mnt", cpioVerbosity())) { + msgConfirm("Couldn't clone the /dev files!"); + return DITEM_FAILURE | DITEM_RESTORE; + } + + /* Mount devfs for other partitions to mount */ + Mkdir("/mnt/dev"); + if (!Fake) + mount("devfs", "/mnt/dev", 0, NULL); } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9456.1007105983>