Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Aug 2001 16:54:43 -0700 (PDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Bruce Evans <bde@FreeBSD.org>
Subject:   RE: cvs commit: src/sys/i386/i386 machdep.c
Message-ID:  <XFMail.010813165443.jhb@FreeBSD.org>
In-Reply-To: <20010814091732.A8344-100000@besplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 13-Aug-01 Bruce Evans wrote:
> On Mon, 13 Aug 2001, John Baldwin wrote:
> 
>> On 13-Aug-01 Bruce Evans wrote:
>> > bde         2001/08/13 06:22:50 PDT
>> >
>> >   Modified files:
>> >     sys/i386/i386        machdep.c
>> >   Log:
>> >   Use interrupt gates instead of trap gates for breakpoint and trace
>> >   traps, so that ddb can keep control (almost) no matter how it is
>> >   entered.  ...
> 
>> I take it the disabling of interrupts in Debugger() can be axed now?
> 
> Yes.  Also in i386-gdbstub.c.
> 
> The anti-reentrancy flag in Debugger() can probably be axed too.  It
> is similarly half-baked and is now unnecessary for preventing reentrance
> via the keyboard interrupt handler.

What if we hit a code path from the Debugger that calls the Debugger() function?
Esp. since we can call any function from ddb if we really want to...

I suppose we could use db_active to test for this?  But that is ddb-specific..

> Bruce

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010813165443.jhb>