Date: Sat, 20 Jul 2024 23:35:02 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: "Sergey A. Osokin" <osa@freebsd.org> Cc: Vladimir Druzenko <vvd@freebsd.org>, Jan Beich <jbeich@freebsd.org>, =?utf-8?Q?Mika=C3=ABl?= Urankar <mikael@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 7b0c8167940b - main - net/ntpd-rs: mark as broken on i386 Message-ID: <4212939331127bcc9bc224d1b5c68d0f@mail.infomaniak.com> In-Reply-To: <ZpwSkuuxUDKcyAGG@FreeBSD.org> References: <202407201533.46KFXTm2012293@gitrepo.freebsd.org> <bk2s-f4r1-wny@FreeBSD.org> <85723896-9eac-4377-b0d9-79911664eedf@FreeBSD.org> <7cdg-aq3y-wny@FreeBSD.org> <3316b5b4-8010-46ee-b5d5-c5d4e5a9294a@freebsd.org> <ZpwSkuuxUDKcyAGG@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-07-20T21:40:02.000+02:00, Sergey A. Osokin <osa@freebsd.org> wrote: > On Sat, Jul 20, 2024 at 10:36:48PM +0300, Vladimir Druzenko wrote: >> 20.07.2024 21:13, Jan Beich пишет: >> >>> Mikaël Urankar <mikael@FreeBSD.org> writes: >>> >>>> On 7/20/24 17:43, Jan Beich wrote: >>>> >>>>> Mikael Urankar <mikael@FreeBSD.org> writes: >>>>> >>>>>> +NOT_FOR_ARCHS= i386 >>>>>> >>>>>> +NOT_FOR_ARCHS_REASON= the ring crate requires SSE2 >>>>>> instruction on intel cpu >>>>> >>>>> Why not pass -C target-feature=+sse2 like games/jumpy >>>>> instead? >>>> >>>> Per [1] we are supposed to target Pentium Pro / Pentium II >>>> (i686), >>>> >>>> sse2 is not available on these cpus. This is enforced in our >>>> rust >>>> >>>> ports with [2]. > > Add my two cents. I've added the following line to the > security/boringssl > > CFLAGS_i386= -msse2 > > I do believe that's enough. > > Thank you. > > -- > > Sergey A. Osokin Hi, Instead "abusing" C/CXX/*FLAGS utilize our framework instead? https://cgit.freebsd.org/ports/tree/audio/libsidplayfp/Makefile#n51 This will also make builds fail if your target lacks said instructions. Best regards, Daniel [-- Attachment #2 --] <html><body><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">On 2024-07-20T21:40:02.000+02:00, Sergey A. Osokin <osa@freebsd.org> wrote:<br></div><div ><div><br></div></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>On Sat, Jul 20, 2024 at 10:36:48PM +0300, Vladimir Druzenko wrote:<br></div><blockquote class="ws-ng-quote"><div> 20.07.2024 21:13, Jan Beich пишет:<br></div><blockquote class="ws-ng-quote"><div> Mikaël Urankar <<a href="mailto:mikael@FreeBSD.org" class="defaultMailLink">mikael@FreeBSD.org</a>> writes:<br></div><div> <br></div><blockquote class="ws-ng-quote"><div> On 7/20/24 17:43, Jan Beich wrote:<br></div><div> <br></div><blockquote class="ws-ng-quote"><div> Mikael Urankar <<a href="mailto:mikael@FreeBSD.org" class="defaultMailLink">mikael@FreeBSD.org</a>> writes:<br></div><div> <br></div><blockquote class="ws-ng-quote"><div> +NOT_FOR_ARCHS= i386<br></div><div> +NOT_FOR_ARCHS_REASON= the ring crate requires SSE2 instruction on intel cpu<br></div></blockquote><div> Why not pass -C target-feature=+sse2 like games/jumpy instead?<br></div></blockquote><div> Per [1] we are supposed to target Pentium Pro / Pentium II (i686),<br></div><div> sse2 is not available on these cpus. This is enforced in our rust<br></div><div> ports with [2].<br></div></blockquote></blockquote></blockquote><div> <br></div><div>Add my two cents. I've added the following line to the security/boringssl<br></div><div><br></div><div>CFLAGS_i386= -msse2<br></div><div><br></div><div>I do believe that's enough.<br></div><div><br></div><div>Thank you.<br></div><div><br></div><div>-- <br></div><div>Sergey A. Osokin<br></div></pre></blockquote></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Hi,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Instead "abusing" C/CXX/*FLAGS utilize our framework instead?<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a href="https://cgit.freebsd.org/ports/tree/audio/libsidplayfp/Makefile#n51" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://cgit.freebsd.org/ports/tree/audio/libsidplayfp/Makefile#n51</a><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">This will also make builds fail if your target lacks said instructions.<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Best regards,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Daniel<br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4212939331127bcc9bc224d1b5c68d0f>