Date: Wed, 19 Sep 2012 12:18:01 +0200 From: Erik Cederstrand <erik@cederstrand.dk> To: FreeBSD Hackers <hackers@FreeBSD.org> Subject: Re: NDEBUG and assert() Message-ID: <D4A468C8-82E8-4E3B-BB20-2384CE17262E@cederstrand.dk> In-Reply-To: <63FCC95F-7D73-423D-892D-DB5D75BCEBE7@cederstrand.dk> References: <63FCC95F-7D73-423D-892D-DB5D75BCEBE7@cederstrand.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Den 19/09/2012 kl. 11.19 skrev Erik Cederstrand <erik@cederstrand.dk>: > The below below patch will let the analyzer reason correctly about the = code, and removes the report mentioned above (and a handful others in = ncurses). It doesn't touch contrib code, but I'm not happy about = changing include/assert.h since it's used so many other places. Any = other ideas for how to best solve this? An alternative that doesn't touch assert.h but contains a patch to = /contrib: Erik Index: lib/ncurses/ncurses/ncurses_cfg.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- lib/ncurses/ncurses/ncurses_cfg.h (revision 240638) +++ lib/ncurses/ncurses/ncurses_cfg.h (working copy) @@ -145,7 +145,6 @@ #define NCURSES_NO_PADDING 1 #define NCURSES_PATHSEP ':' #define NCURSES_VERSION_STRING "5.7.20081102" -#define NDEBUG 1 #define RETSIGTYPE void #define SIG_ATOMIC_T volatile sig_atomic_t #define SIZEOF_SIGNED_CHAR 1 Index: lib/ncurses/config.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- lib/ncurses/config.mk (revision 240638) +++ lib/ncurses/config.mk (working copy) @@ -27,8 +27,6 @@ =20 CFLAGS+=3D -Wall =20 -CFLAGS+=3D -DNDEBUG - CFLAGS+=3D -DHAVE_CONFIG_H =20 # everyone needs this Index: contrib/ncurses/include/ncurses_defs =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- contrib/ncurses/include/ncurses_defs (revision 240638) +++ contrib/ncurses/include/ncurses_defs (working copy) @@ -171,7 +171,6 @@ NCURSES_EXT_FUNCS NCURSES_NO_PADDING NCURSES_PATHSEP ':' -NDEBUG NEED_PTEM_H NO_LEAKS PURE_TERMINFO
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D4A468C8-82E8-4E3B-BB20-2384CE17262E>