Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Nov 2025 20:28:47 +0000
From:      Andrey V. Elsukov <ae@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Cc:        Boris Lytochkin <lytboris@gmail.com>
Subject:   git: ff3c48a64fe2 - stable/15 - ipfw: fix lookup dst-ip opcode
Message-ID:  <6924bfff.29a8b.6dc58e0d@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/15 has been updated by ae:

URL: https://cgit.FreeBSD.org/src/commit/?id=ff3c48a64fe2f9c1acf531e088dfb14e31404bae

commit ff3c48a64fe2f9c1acf531e088dfb14e31404bae
Author:     Boris Lytochkin <lytboris@gmail.com>
AuthorDate: 2025-11-18 10:31:56 +0000
Commit:     Andrey V. Elsukov <ae@FreeBSD.org>
CommitDate: 2025-11-24 20:28:09 +0000

    ipfw: fix lookup dst-ip opcode
    
    Opcode handling should not fall through to the LOOKUP_DSCP type.
    
    Reviewed by:    melifaro
    Obtained from:  Yandex LLC
    Differential Revision:  https://reviews.freebsd.org/D53775
    
    (cherry picked from commit 8012c61bef3bb19a48d8459b38b65e27d46c186c)
---
 sys/netpfil/ipfw/ip_fw2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/netpfil/ipfw/ip_fw2.c b/sys/netpfil/ipfw/ip_fw2.c
index b59d8d08bf80..2b7f38d2e9a6 100644
--- a/sys/netpfil/ipfw/ip_fw2.c
+++ b/sys/netpfil/ipfw/ip_fw2.c
@@ -2120,8 +2120,8 @@ do {								\
 							pkey = &args->f_id.dst_ip6;
 						else
 							pkey = &args->f_id.src_ip6;
-					} else /* only for L3 */
-						break;
+					}
+					break;
 				case LOOKUP_DSCP:
 					if (is_ipv4)
 						key = ip->ip_tos >> 2;


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6924bfff.29a8b.6dc58e0d>