Date: Fri, 15 Jan 2010 13:41:33 -0500 From: Greg Larkin <glarkin@FreeBSD.org> To: Torfinn Ingolfsen <tingox@gmail.com> Cc: demon@freebsd.org, FreeBSD Ports ML <freebsd-ports@freebsd.org> Subject: Re: sysutils/xfce4-netload-plugin - why is it marked as broken on 8? Message-ID: <4B50B6DD.6040600@FreeBSD.org> In-Reply-To: <ef8c8a881001150645kb0cc5fcpc37de51e77f72316@mail.gmail.com> References: <ef8c8a881001141542n7d706477sf9c2258ead2c70c7@mail.gmail.com> <4B4FB10D.5040905@FreeBSD.org> <20100115001412.138ed882@gumby.homeunix.com> <ef8c8a881001150645kb0cc5fcpc37de51e77f72316@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Torfinn Ingolfsen wrote: > Hi, > > On Fri, Jan 15, 2010 at 1:14 AM, RW <rwmaillists@googlemail.com> wrote: > >> On Thu, 14 Jan 2010 19:04:29 -0500 >> Greg Larkin <glarkin@FreeBSD.org> wrote: >> >> >>> The CVS commit in question says that the breakage was reported by >>> pointyhat (FreeBSD package building cluster): >>> >> http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/xfce4-netload-plugin/Makefile#rev1.28 >>> In fact, pav@ included the specific compiler error. I wonder if there >>> was possibly a bug in the early 8.0 OS at that time (13 Jun 2009) that >>> caused the build failure. >>> >>> If you are able to build and run successfully under 8.0 now, I suggest >>> filing a PR with a patch to unbreak the port. >> I just tried it and it failed on 8.0 (RELENGE_8_0), the OP is using >> 8-stable. >> > > Well, shouldn't the port only be marked broken for RELENG_8_0 (and perhaps > -CURRENT) then, and not for RELENG_8? > I don't know how to do that, or I would file a PR. Hi Torfinn, There's an explanation of what happened to if_ppp.h here: http://www.mail-archive.com/svn-src-all@freebsd.org/msg07293.html This commit log refers to the fact that the value of __FreeBSD_version was bumped to 800045 due to the removal of the if_ppp(4) driver. You can find all of the historical values of that variable here: http://www.freebsd.org/doc/en/books/porters-handbook/freebsd-versions.html In this case, the port Makefile should be patched like so: - --- Makefile.orig 2010-01-15 13:37:50.374330422 -0500 +++ Makefile 2010-01-15 13:38:04.101133409 -0500 @@ -24,7 +24,7 @@ .include <bsd.port.pre.mk> - -.if ${OSVERSION} >= 800000 +.if ${OSVERSION} >= 800045 BROKEN= does not compile: error: net/if_ppp.h: No such file or directory .endif A better fix might be to port the code from using if_ppp(4) to the replacement ppp(8), as noted in the commit log. Regards, Greg - -- Greg Larkin http://www.FreeBSD.org/ - The Power To Serve http://www.sourcehosting.net/ - Ready. Set. Code. http://twitter.com/sourcehosting/ - Follow me, follow you -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iD8DBQFLULbd0sRouByUApARAhzAAJ9QWrqCN1N/JRLF9RO4Rr/MBN76dgCfX4DH tBd6gqJctCM0UFPCVi4TRiM= =n8+3 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B50B6DD.6040600>