Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 May 2019 13:42:56 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r346991 - stable/12/sys/geom
Message-ID:  <201905011342.x41DguhG017960@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Wed May  1 13:42:56 2019
New Revision: 346991
URL: https://svnweb.freebsd.org/changeset/base/346991

Log:
  MFC r346644: Call delist_dev() before destroy_dev_sched_cb().
  
  destroy_dev_sched_cb() is excessively asynchronous, and during media change
  retaste new provider may appear sooner then device of the previous one get
  destroyed.
  
  Sponsored by:	iXsystems, Inc.

Modified:
  stable/12/sys/geom/geom_dev.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/geom/geom_dev.c
==============================================================================
--- stable/12/sys/geom/geom_dev.c	Wed May  1 13:15:06 2019	(r346990)
+++ stable/12/sys/geom/geom_dev.c	Wed May  1 13:42:56 2019	(r346991)
@@ -838,6 +838,7 @@ g_dev_orphan(struct g_consumer *cp)
 		(void)clear_dumper(curthread);
 
 	/* Destroy the struct cdev *so we get no more requests */
+	delist_dev(dev);
 	destroy_dev_sched_cb(dev, g_dev_callback, cp);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905011342.x41DguhG017960>