Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 Sep 2018 23:28:35 +0000 (UTC)
From:      Kirk McKusick <mckusick@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r338517 - head/sys/ufs/ffs
Message-ID:  <201809062328.w86NSZO4098832@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mckusick
Date: Thu Sep  6 23:28:35 2018
New Revision: 338517
URL: https://svnweb.freebsd.org/changeset/base/338517

Log:
  The Call For Testing had no reports of operational problems and
  found that performance was no worse and usually better when running
  with TRIM consolidation. Performance improvement was most noticable
  when multiple large files are released in a short period of time.
  
  Thus, TRIM consolidation is being enabled by default. Should
  operational problems be found, it can be disabled using the command
  `sysctl vfs.ffs.dotrimcons=0'. This variable can also be set as a
  tunable if early disabling is necessary.
  
  Approved by:  re (gjb)
  Sponsored by: Netflix

Modified:
  head/sys/ufs/ffs/ffs_alloc.c

Modified: head/sys/ufs/ffs/ffs_alloc.c
==============================================================================
--- head/sys/ufs/ffs/ffs_alloc.c	Thu Sep  6 22:32:59 2018	(r338516)
+++ head/sys/ufs/ffs/ffs_alloc.c	Thu Sep  6 23:28:35 2018	(r338517)
@@ -484,8 +484,8 @@ static int doreallocblks = 1;
 SYSCTL_INT(_vfs_ffs, OID_AUTO, doreallocblks, CTLFLAG_RW, &doreallocblks, 0,
 "enable block reallocation");
 
-static int dotrimcons = 0;
-SYSCTL_INT(_vfs_ffs, OID_AUTO, dotrimcons, CTLFLAG_RW, &dotrimcons, 0,
+static int dotrimcons = 1;
+SYSCTL_INT(_vfs_ffs, OID_AUTO, dotrimcons, CTLFLAG_RWTUN, &dotrimcons, 0,
 "enable BIO_DELETE / TRIM consolidation");
 
 static int maxclustersearch = 10;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809062328.w86NSZO4098832>