Date: Tue, 03 Mar 2009 02:16:58 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Alexander Motin <mav@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189295 - head/sys/dev/ata/chipsets Message-ID: <1236064618.37252.169.camel@shumai.marcuscom.com> In-Reply-To: <200903030639.n236dcYs000461@svn.freebsd.org> References: <200903030639.n236dcYs000461@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, 2009-03-03 at 06:39 +0000, Alexander Motin wrote: > Author: mav > Date: Tue Mar 3 06:39:38 2009 > New Revision: 189295 > URL: http://svn.freebsd.org/changeset/base/189295 > > Log: > Set PortMultiplier port only for SATA2 channels, where it is applicable. > Doing it on old SATA controllers like Promise PDC20375 SATA150 breaks > their operation. Thanks! My Tinderbox machine thanks you as well. Joe > > Tested by: marcus on PDC20375 > > Modified: > head/sys/dev/ata/chipsets/ata-promise.c > > Modified: head/sys/dev/ata/chipsets/ata-promise.c > ============================================================================== > --- head/sys/dev/ata/chipsets/ata-promise.c Tue Mar 3 03:33:25 2009 (r189294) > +++ head/sys/dev/ata/chipsets/ata-promise.c Tue Mar 3 06:39:38 2009 (r189295) > @@ -690,8 +690,11 @@ ata_promise_mio_command(struct ata_reque > > ATA_OUTL(ctlr->r_res2, (ch->unit + 1) << 2, 0x00000001); > > - /* set portmultiplier port */ > - ATA_OUTB(ctlr->r_res2, 0x4e8 + (ch->unit << 8), atadev->unit & 0x0f); > + if ((ctlr->chip->cfg2 == PR_SATA2) || > + ((ctlr->chip->cfg2 == PR_CMBO2) && (ch->unit < 2))) { > + /* set portmultiplier port */ > + ATA_OUTB(ctlr->r_res2, 0x4e8 + (ch->unit << 8), atadev->unit & 0x0f); > + } > > /* XXX SOS add ATAPI commands support later */ > switch (request->u.ata.command) { > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > -- PGP Key : http://www.marcuscom.com/pgp.asc [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkms2WkACgkQb2iPiv4Uz4eGlQCfWTtppeAPEPuKwLwCNL3XV2Pr FzYAn3bVb3EEB55dnoQHbkbtXJPvvGkc =Qhvk -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1236064618.37252.169.camel>