Date: Thu, 13 Sep 2001 00:37:17 +0000 From: Tony Finch <dot@dotat.at> To: FreeBSD-gnats-submit@freebsd.org Subject: bin/30538: [PATCH] ownerships pedantry Message-ID: <E15hKVJ-0001UB-00@hand.dotat.at>
next in thread | raw e-mail | index | archive | help
>Number: 30538
>Category: bin
>Synopsis: [PATCH] ownerships pedantry
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Sep 12 16:40:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator: Tony Finch
>Release: FreeBSD 4.4-RC i386
>Organization:
dotat labs
>Environment:
System: FreeBSD hand.dotat.at 4.4-RC FreeBSD 4.4-RC #4: Sat Sep 1 19:06:27 GMT 2001 fanf@hand.dotat.at:/FreeBSD/obj/FreeBSD/releng4/sys/SHARP i386
>Description:
A number of programs set BINOWN and BINGRP to non-standard values
for no obvious reason. They are:
ping6
traceroute6
doscmd
There are also some oddities in the games handling in bsd.prog.mk
which fails to set the ownership of a hidden game symlink correctly.
>How-To-Repeat:
>Fix:
Index: sbin/ping6/Makefile
===================================================================
RCS file: /home/ncvs/src/sbin/ping6/Makefile,v
retrieving revision 1.1.2.2
diff -u -r1.1.2.2 Makefile
--- sbin/ping6/Makefile 2001/04/25 10:58:46 1.1.2.2
+++ sbin/ping6/Makefile 2001/06/27 18:25:29
@@ -5,8 +5,6 @@
CFLAGS+=-DINET6 -DIPSEC
-BINOWN= root
-BINGRP= bin
BINMODE=4555
LDADD= -lipsec -lmd
Index: usr.sbin/traceroute6/Makefile
===================================================================
RCS file: /home/ncvs/src/usr.sbin/traceroute6/Makefile,v
retrieving revision 1.2.2.2
diff -u -r1.2.2.2 Makefile
--- usr.sbin/traceroute6/Makefile 2001/04/25 12:11:06 1.2.2.2
+++ usr.sbin/traceroute6/Makefile 2001/06/27 18:26:13
@@ -15,8 +15,6 @@
PROG= traceroute6
-BINOWN= root
-BINGRP= bin
BINMODE=4555
CFLAGS+=-DINET6 -DIPSEC -DHAVE_POLL
Index: share/mk/bsd.prog.mk
===================================================================
RCS file: /home/ncvs/src/share/mk/bsd.prog.mk,v
retrieving revision 1.86.2.4
diff -u -r1.86.2.4 bsd.prog.mk
--- share/mk/bsd.prog.mk 2001/08/01 17:14:26 1.86.2.4
+++ share/mk/bsd.prog.mk 2001/09/07 17:35:20
@@ -107,7 +107,7 @@
.endif
.if defined(HIDEGAME)
(cd ${DESTDIR}/${GBINDIR}; rm -f ${PROG}; ln -s dm ${PROG}; \
- chown games:bin ${PROG})
+ chown -h ${BINOWN}:${BINGRP} ${PROG})
.endif
.if defined(LINKS) && !empty(LINKS)
@set ${LINKS}; \
Index: usr.bin/doscmd/Makefile
===================================================================
RCS file: /home/ncvs/src/usr.bin/doscmd/Makefile,v
retrieving revision 1.21.2.3
diff -u -r1.21.2.3 Makefile
--- usr.bin/doscmd/Makefile 2001/08/02 02:17:15 1.21.2.3
+++ usr.bin/doscmd/Makefile 2001/08/28 22:22:53
@@ -22,7 +22,6 @@
.endif
BINGRP= kmem
-EXEGRP= bin
#BINMODE= 2555
EXEMODE= 444
@@ -37,15 +36,15 @@
beforeinstall:
.if ${OBJFORMAT} == "aout"
- ${INSTALL} ${COPY} -o ${BINOWN} -g ${EXEGRP} -m ${EXEMODE} \
+ ${INSTALL} ${COPY} -o ${BINOWN} -g ${BINGRP} -m ${EXEMODE} \
doscmd.kernel ${DESTDIR}/usr/libexec/
.endif
- ${INSTALL} ${COPY} -o ${BINOWN} -g ${EXEGRP} -m ${EXEMODE} \
+ ${INSTALL} ${COPY} -o ${BINOWN} -g ${BINGRP} -m ${EXEMODE} \
emsdriv.sys redir.com ${DESTDIR}/usr/libdata/doscmd/
- ${INSTALL} ${COPY} -o ${BINOWN} -g ${EXEGRP} -m ${SHAREMODE} \
+ ${INSTALL} ${COPY} -o ${BINOWN} -g ${BINGRP} -m ${SHAREMODE} \
cp437-8x16.pcf.gz ${DESTDIR}/usr/libdata/doscmd/fonts
cd ${.CURDIR} && \
- ${INSTALL} ${COPY} -o ${BINOWN} -g ${EXEGRP} -m ${SHAREMODE} \
+ ${INSTALL} ${COPY} -o ${BINOWN} -g ${BINGRP} -m ${SHAREMODE} \
fonts.dir ${DESTDIR}/usr/libdata/doscmd/fonts
.if ${OBJFORMAT} == "aout"
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E15hKVJ-0001UB-00>