Date: Fri, 23 Oct 2020 01:46:31 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: Alan Somers <asomers@freebsd.org>, freebsd-fs <freebsd-fs@freebsd.org> Subject: Re: Always-0 NFS statistics Message-ID: <YTBPR01MB396692E2EC66728FBB692231DD1A0@YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <CAOtMX2jW_3dg6=EiM=xJNs5F5EYveaE4ShGZFAXcFNbxJuoRMw@mail.gmail.com> References: <CAOtMX2jW_3dg6=EiM=xJNs5F5EYveaE4ShGZFAXcFNbxJuoRMw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Alan Somers wrote:=0A= >It looks to me like three of the server statistics published by nfsstat ar= e=0A= >always 0. At least, cscope can't find any location in the kernel that set= s=0A= >these variables. Are they legitimately always zero in FreeBSD's=0A= >implementation of NFS, or are they reserved for future features, or is thi= s=0A= >a mistake? The stats are:=0A= >=0A= >nfsstat's name kernel name=0A= >Retfailed srv_errs=0A= >Faults srvrpc_errs=0A= >Idem srvcache_idemdonehits=0A= I believe these are left over from when the code was originally written=0A= for OpenBSD2.6, which did not have a separate kernel RPC, where the=0A= NFS code did the RPC calls.=0A= =0A= I suppose they should have been deleted from the FreeBSD port once=0A= it was incorporated into FreeBSD using the kernel RPC, but they were=0A= not.=0A= =0A= Revising the nfsstats structure yet again is a bother.=0A= I suppose you could modify nfsstats.c so that it never displays these=0A= fields. I doubt that would be considered a POLA violation.=0A= =0A= rick=0A= =0A= =0A= _______________________________________________=0A= freebsd-fs@freebsd.org mailing list=0A= https://lists.freebsd.org/mailman/listinfo/freebsd-fs=0A= To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org"=0A= =0A=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YTBPR01MB396692E2EC66728FBB692231DD1A0>