Date: Tue, 12 May 2015 15:35:55 +0000 From: "ian (Ian Lepore)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Commented On] D2377: Introduce ARM GICv3 support Message-ID: <ab5e2d66d0956fa2e266c31a1ee57d22@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org> References: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
ian added inline comments.
INLINE COMMENTS
sys/arm64/arm64/gic_v3.c:163 This comment is now completely detached from the code it was commenting on.
My point was that these two lines are equivelent:
(*init_func)();
init_func();
When you've got a pointer to a function, the compiler knows that, there's no need to add parens and a star to make it call through the pointer.
REVISION DETAIL
https://reviews.freebsd.org/D2377
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ab5e2d66d0956fa2e266c31a1ee57d22>