Date: Thu, 14 Dec 2000 18:36:31 -0500 From: Chris Faulhaber <jedgar@fxp.org> To: "Michael C . Wu" <keichii@peorth.iteration.net> Cc: freebsd-audit@freebsd.org Subject: Re: libintl audit. Message-ID: <20001214183631.A30242@earth.causticlabs.com> In-Reply-To: <20001213180945.A79894@peitho.fxp.org>; from jedgar@fxp.org on Wed, Dec 13, 2000 at 06:09:45PM -0500 References: <20001213163638.A17119@peorth.iteration.net> <20001213180945.A79894@peitho.fxp.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 13, 2000 at 06:09:45PM -0500, Chris Faulhaber wrote:
> On Wed, Dec 13, 2000 at 04:36:38PM -0600, Michael C . Wu wrote:
> > Hello guys,
> >
> > Will someone audit the attached tarball for me? :)
> >
>
> So far: you should probably check the return values of strdup(3) calls.
>
> I will take a closer look at the code when I get a chance this evening :)
>
One other nit:
--- gettext.c.orig Wed Dec 6 02:39:35 2000
+++ gettext.c Thu Dec 14 18:17:34 2000
@@ -336,7 +336,7 @@
}
mohandle.addr = mmap(NULL, (size_t)st.st_size, PROT_READ,
MAP_FILE | MAP_SHARED, fd, (off_t)0);
- if (!mohandle.addr) {
+ if (mohandle.addr == MAP_FAILED) {
close(fd);
goto fail;
}
--
Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org
--------------------------------------------------------
FreeBSD: The Power To Serve - http://www.FreeBSD.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001214183631.A30242>