Date: Mon, 20 Apr 2020 10:33:55 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: "Jonathan T. Looney" <jtl@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r360019 - head/tests/sys/kern Message-ID: <1FC4B1BE-B147-466D-B01D-F4A670516FF1@gmail.com> In-Reply-To: <CADrOrmsq3dCKJbTsbymR9Jyoz8Xw6Jjca9Wsz0rJSsTG_6O=iQ@mail.gmail.com> References: <202004162007.03GK7Zgr089624@repo.freebsd.org> <C8F21B73-F46F-49C2-8A35-0F6D0959F3CD@gmail.com> <CADrOrmsq3dCKJbTsbymR9Jyoz8Xw6Jjca9Wsz0rJSsTG_6O=iQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 20, 2020, at 10:10 AM, Jonathan T. Looney <jtl@FreeBSD.org> = wrote: >=20 > On Sun, Apr 19, 2020 at 5:03 PM Enji Cooper <yaneurabeya@gmail.com = <mailto:yaneurabeya@gmail.com>> wrote: >=20 > > On Apr 16, 2020, at 1:07 PM, Jonathan T. Looney <jtl@FreeBSD.org> = wrote: > >=20 > > Author: jtl > > Date: Thu Apr 16 20:07:34 2020 > > New Revision: 360019 > > URL: https://svnweb.freebsd.org/changeset/base/360019 = <https://svnweb.freebsd.org/changeset/base/360019> > >=20 > > Log: > > Add a regression test for the changes in r359922 and r359923. > >=20 > > Note that the Python code has been tested on both Python 2.7 and = 3.7. > >=20 > > Reviewed by: olivier > > MFC after: 2 weeks > > Sponsored by: Netflix, Inc. >=20 > Ugh=E2=80=A6 I can tell by this commit that I just need to add = pytest support to kyua >_>=E2=80=A6 >=20 > I assume you're suggesting that we support running Python code = natively, instead of from a shell script. If so, I think that's a great = idea. >=20 > It looks like we're growing a number of Python scripts in the test = suite, and supporting them more natively is probably good for more than = one reason. That was exactly my thinking. The reason why I picked pytest is = that nose 1.x is abandoned, nose 2.x converges with pytest (and the page = recommends pytest), and raw unittest requires a lot of complexity. = Another plus of pytest is that it has an extensible plugin framework. It=E2=80=99s really unfortunate that we don=E2=80=99t have = better package integration in buildworld. It would make building and = installing tests a lot easier. Cheers, -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1FC4B1BE-B147-466D-B01D-F4A670516FF1>