Date: Mon, 26 Jun 2017 15:34:40 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Ngie Cooper <yaneurabeya@gmail.com> Cc: Ngie Cooper <ngie@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r320222 - in stable/10: etc etc/cron.d etc/mtree etc/newsyslog.conf.d etc/pam.d etc/syslog.d tools/build/mk usr.sbin/cron/cron usr.sbin/cron/lib usr.sbin/syslogd Message-ID: <126a318e-61a3-bfdc-e1dd-b16a67734d30@FreeBSD.org> In-Reply-To: <52481168-DCDD-4D6A-8F68-1EBDA44513D1@gmail.com> References: <201706220708.v5M78IYv080609@repo.freebsd.org> <bd506dd1-4f0c-820b-cf31-b41416f7e9b1@FreeBSD.org> <223428BC-9035-4435-B8EB-9A72EDCDD225@gmail.com> <f9d18800-4813-fccd-4955-17c71deafe8a@FreeBSD.org> <52481168-DCDD-4D6A-8F68-1EBDA44513D1@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/22/17 10:08 AM, Ngie Cooper wrote:
>
>> On Jun 22, 2017, at 03:28, John Baldwin <jhb@FreeBSD.org> wrote:
>>
>>> On 6/22/17 4:02 AM, Ngie Cooper (yaneurabeya) wrote:
>>>
>>>> On Jun 22, 2017, at 00:35, John Baldwin <jhb@freebsd.org> wrote:
>>>
>>> c
>>>
>>>> Please revert the breakout of the existing config files. I think that splitting
>>>> up the conf files is too disruptive of a change (POLA) for stable branches.
>>>
>>> Done in r320229 and r320230.
>>
>> I haven't checked if this was merged to 11, but if so, I think they should also
>> stay a single conf file in 11 for the same reason.
>
> No, it wasn't merged to 11, so no further action required here.
>
>>>> This was agreed to by other folks in the followup thread to the commits in
>>>> head that you continue to ignore.
>>>
>>>
>>>> In head please either fully split up the files or revert to a single file
>>>> (another part of that thread you continue to ignore).
>>>
>>> My eyes glazed over trying to read through all of the posts. I seem to have missed the point where a proposed change was made to split up the config files further. Could this please be summarized again?
>>
>> I think that having the files partially split up is the worst of both
>> worlds as folks writing config management rules, etc. have to use
>> different approaches depending on the rule. I think that is a headache
>> and would rather have the config either be all in a single file, or all
>> be split up into conf.d/ so that it is consistent. I also think that
>> when splitting up a conf file we should do it all at once so that there is
>> only one painful /etc merge instead of several of them.
>
> This still doesn't answer my concern fully. In what way are the config files in base not broken down 100%, i.e., what action can I take to resolve your concerns about it not being fully modularized? I think syslog.conf having kerberos.log is likely the last issue, but I would really like clarification in order to move forward.
Hmm, I had assumed that in a fully modularized form we wouldn't have foo.conf
at all, but _only_ files in conf.d. However, looking at the files it does seem
that there are some system-wide entries that aren't part of a specific program
and that those should probably stay in foo.conf. I do think there are some
remaining entries that are for a single program though:
For syslog.conf:
- /var/log/cron probably belongs in /etc/syslog.d/cron.conf?
- commented out lines for /var/log/devd.log belong in /etc/syslogd.d/devd.conf?
For newsyslog.conf:
- /var/log/cron -> cron.conf
- /var/log/{daily,monthly,security,weekly}.log -> periodic.conf
- /var/log/init.log -> init.conf?
- /var/log/kerberos.log -> kerberos.conf
- /var/log/devd.log -> devd.conf
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?126a318e-61a3-bfdc-e1dd-b16a67734d30>