Date: Tue, 28 Aug 2018 20:22:20 +0000 From: bugzilla-noreply@freebsd.org To: dtrace@FreeBSD.org Subject: [Bug 230846] dtrace FBT doesn't know about ifuncs Message-ID: <bug-230846-32976-HUh5oAz8LV@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-230846-32976@https.bugs.freebsd.org/bugzilla/> References: <bug-230846-32976@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230846 --- Comment #4 from commit-hook@freebsd.org --- A commit references this bug: Author: markj Date: Tue Aug 28 20:21:38 UTC 2018 New revision: 338359 URL: https://svnweb.freebsd.org/changeset/base/338359 Log: Allow multiple FBT probes to share a tracepoint. With GNU ifuncs, multiple FBT probes may correspond to the same instruction. fbt_invop() assumed that this could not happen and would return after the first probe found in the global FBT hash table, which might not be the one that's enabled. Fix the problem on x86 by linking probes that share a tracepoint and having each linked probe fire when the tracepoint is hit. PR: 230846 Approved by: re (gjb) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D16921 Changes: head/sys/cddl/dev/fbt/aarch64/fbt_isa.c head/sys/cddl/dev/fbt/arm/fbt_isa.c head/sys/cddl/dev/fbt/fbt.c head/sys/cddl/dev/fbt/fbt.h head/sys/cddl/dev/fbt/mips/fbt_isa.c head/sys/cddl/dev/fbt/powerpc/fbt_isa.c head/sys/cddl/dev/fbt/riscv/fbt_isa.c head/sys/cddl/dev/fbt/x86/fbt_isa.c --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230846-32976-HUh5oAz8LV>