Date: Sun, 12 Sep 2004 20:10:55 GMT From: Giorgos Keramidas <keramida@freebsd.org> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/71616: [PATCH] cleanup of the usr.sbin/yp_mkdb code Message-ID: <200409122010.i8CKAtIb028207@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/71616; it has been noted by GNATS. From: Giorgos Keramidas <keramida@freebsd.org> To: Dan Lukes <dan@obluda.cz> Cc: bug-followup@freebsd.org Subject: Re: bin/71616: [PATCH] cleanup of the usr.sbin/yp_mkdb code Date: Sun, 12 Sep 2004 21:23:45 +0300 On 2004-09-12 04:37, Dan Lukes <dan@obluda.cz> wrote: > *** usr.sbin/yp_mkdb/yp_mkdb.c.ORIG Sun Sep 5 18:54:07 2004 > --- usr.sbin/yp_mkdb/yp_mkdb.c Sun Sep 5 19:01:20 2004 > [...] > - snprintf(buf, sizeof(buf), "%lu", time(NULL)); > + snprintf(buf, sizeof(buf), "%lu", (long unsigned int)time(NULL)); Just a minor comment: An (unsigned long) cast should be fine here. There's no need to add `int' and the ordering of long unsigned seems a bit backwards -- most of the time I've seen it written with `unsigned' first. - Giorgos
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409122010.i8CKAtIb028207>