Date: Tue, 12 Dec 2006 22:23:17 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: rizzo@icir.org Cc: gurney_j@resnet.uoregon.edu, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, luigi@FreeBSD.org, cvs-all@FreeBSD.org, ticso@cicely.de Subject: Re: cvs commit: src/sys/net if_ethersubr.c Message-ID: <20061212.222317.1021576677.imp@bsdimp.com> In-Reply-To: <20061212203002.A51749@xorpc.icir.org> References: <20061212.140133.1649770385.imp@bsdimp.com> <20061212.211323.-1573945956.imp@bsdimp.com> <20061212203002.A51749@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20061212203002.A51749@xorpc.icir.org>
Luigi Rizzo <rizzo@icir.org> writes:
: On Tue, Dec 12, 2006 at 09:13:23PM -0700, M. Warner Losh wrote:
: > In message: <20061212.140133.1649770385.imp@bsdimp.com>
: ...
: > : while established practice in NetBSD, met with considerable
: > : controversy when I tried to expand it in FreeBSD land. However,
: > : putting things in param.h met with no resistance whatsoever and was
: > : actively suggested. Maybe we should move this straggler from _types.h
: > : to param.h and start using it more often.
: > :
: > : Warner
: > :
: >
: > Here's what I came up with this afternoon between fires at work.
: >
: > Comments?
:
: makes sense - there are probably more places where it should
: be used (judging by the output of "grep -r __sparc64__ sys/")
Yes. I was going to do a complete audit, but wanted to get the
basic concepts signed off on first.
: just to make sure - are we guaranteed that param.h is included
: by every kernel file, or there is the risk that someone forgets
: it thus missing the #define __NO_STRICT_ALIGNMENT ?
I believe that we are... The result of the discussion last time was
that's a pretty safe bet.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061212.222317.1021576677.imp>