Date: Tue, 16 Jul 2019 15:44:54 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Brooks Davis <brooks@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350049 - head/contrib/amd/amd Message-ID: <20190716194454.odytcdjtlduliz6l@mutt-hbsd> In-Reply-To: <201907161603.x6GG38oZ020228@repo.freebsd.org> References: <201907161603.x6GG38oZ020228@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4sd5ly7yvjmy2vpg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 16, 2019 at 04:03:08PM +0000, Brooks Davis wrote: > Author: brooks > Date: Tue Jul 16 16:03:08 2019 > New Revision: 350049 > URL: https://svnweb.freebsd.org/changeset/base/350049 >=20 > Log: > Fix two mismatches between function declaration and definition. > =20 > In both cases, function pointer arguments were inconsistently declared > and the result worked because of C's odd rules around function pointer > (de)references. With a stricter compiler these fail to compile. And, with CFI applied to the kernel, would cause a panic. :) Good catch and thanks for the great work! --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 --4sd5ly7yvjmy2vpg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl0uKTEACgkQ/y5nonf4 4fpY3xAAqKnAegT4e8E2L6pUei14CJwB6Od2xAgXmGf/IiAxsqVRRTuV2XMJMBHc 7cpVlr7pbaOijABDKXvDShOweS4ZobME1nhklLuz88dpr+CvqqZg3Rg5W9sSJFy7 uCk2Gcs66pGipMZr1yXk8ZhgmucmZRWywJHqL0cvsWamW/KF68D+Kk7+XhJZ8sJW /TneAyXBZ4JaFCkbktPXanoNliIcd/YqHDj7s1Y9SdEjc8n3+wscq4s9FkdONlBD /ysPwp31X5RZdTD6xr7g0qvwSRsGygZMXYQzSRfJNGVqaQmhllzdRDTQhfzcL6FU zzPLuFFddiv7Jzlq77t12Vctl2qLaDcUOPsN7j/XMEgud41086sXtN8OWMX6F3Ay fpV4OtmBnpZejcCLjy2/Vgkoy1tT3jou5xSj2yZW94ttYHyh+DpdgZyUkL6cMlrd QFg1uuJsHmTICaCEYickH7qXzVOqsQTjrVZUeQZquNLW7+Fn4z6TjXDVb2tMfob7 L8MKK5g4aLm7CKJ79VJqVJ3ITnD+rKio74sxXxuHxqrW0cXI1ntd430jRu0adZIN 85I2yMxzWEFFMCFmc31xIEgKj8luBMsrY3kq9vbZSWI4cAd9aK97Z49p8aDOPZ33 GEPBv4D24Jr0mfYWcZco80uViV+q/bv64H8I3i1ikjezzZZ0LL0= =aQZI -----END PGP SIGNATURE----- --4sd5ly7yvjmy2vpg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190716194454.odytcdjtlduliz6l>