Date: Wed, 15 Aug 2018 11:37:28 -0600 From: Adam Weinberger <adamw@adamw.org> To: kevans@freebsd.org Cc: rgrimes@freebsd.org, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, emaste@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r337826 - stable/11/bin/ls Message-ID: <CAP7rwchThdfCGNKJe%2B4Cpn1P8obFeuFj793x0XBHJpMipWEwAA@mail.gmail.com> In-Reply-To: <CACNAnaFVSSWEeftK54DyQHd6d_Dk5bLtF6a17MzwBz3fLjftbA@mail.gmail.com> References: <CAPyFy2CXe5uUu_OwsUiS2xK61bK9ccFYOyD=p6v9=Do3yGWwqw@mail.gmail.com> <201808151607.w7FG7Smo048317@pdx.rh.CN85.dnsmgr.net> <CACNAnaFVSSWEeftK54DyQHd6d_Dk5bLtF6a17MzwBz3fLjftbA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 15, 2018 at 11:31 AM Kyle Evans <kevans@freebsd.org> wrote: > > On Wed, Aug 15, 2018 at 11:07 AM, Rodney W. Grimes > <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > [ Charset UTF-8 unsupported, converting... ] > >> On 14 August 2018 at 21:41, Rodney W. Grimes > >> <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > >> >> Author: kevans > >> >> Date: Wed Aug 15 01:29:02 2018 > >> >> New Revision: 337826 > >> >> URL: https://svnweb.freebsd.org/changeset/base/337826 > >> >> > >> >> Log: > >> >> MFC r337506: ls(1): Enable colors with COLORTERM is set in the environment > >> >> > >> >> COLORTERM is the de facto standard, while CLICOLOR is generally specific to > >> >> FreeBSD and ls(1). > >> > > >> > I have already seen one "Who enabled %&*@(#$@) colored ls output in 12?" > >> > Seems that the defaults for xfce terminal is to have COLORTERM. > >> > >> If xfce's default is to request colour via the de-facto environment > >> variable then we should generally honour it -- the answer to the > >> %&*@(#$@) question is "you did, via your terminal's default." > > > > And I pointed that out to them, but it is kinda a POLA, people have > > had to take explicit action to get colorls, that is no longer true > > and that suprises them when they see it. > > > > I find the POLA angle kind-of hard to buy, though. Nothing in the base > system offers a way for the default behavior of ls(1) to be altered, > and this whole change is only honoring a de-facto standard for > indicating that a colored terminal is supported and desired. > > IMO, one should be aware of how the software they use is affecting > their environment and the kinds of repercussions these changes may > have. This is hardly the first bit of software that respects > COLORTERM, and it surely won't be the last (in general... no specific > plans here). =( Respecting the same env var that other OS's do seems like a reduction in POLA. Please consider putting a note in one or more of /usr/src/UPDATING, /usr/ports/UPDATING, and xfce/pkg-message explaining the change and what people should do to get the old behaviour. They're the best tools we have for improving POLA. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwchThdfCGNKJe%2B4Cpn1P8obFeuFj793x0XBHJpMipWEwAA>