Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 07 Jan 2012 22:37:41 -0500
From:      Steve Wills <swills@FreeBSD.org>
To:        Alexander Logvinov <avl@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/audio Makefile ports/audio/shairport Makefile distinfo pkg-descr ports/audio/shairport/files shairport.in
Message-ID:  <4F090F85.8000502@FreeBSD.org>
In-Reply-To: <201201071124.q07BOLTp087070@repoman.freebsd.org>
References:  <201201071124.q07BOLTp087070@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

On 01/07/12 06:24, Alexander Logvinov wrote:
> avl         2012-01-07 11:24:21 UTC
> 
> FreeBSD ports repository
> 
> Modified files: audio                Makefile Added files: 
> audio/shairport      Makefile distinfo pkg-descr 
> audio/shairport/files shairport.in Log: This program emulates an 
> AirPort Express for the purpose of streaming music from iTunes and 
> compatible iPods. It implements a server for the Apple RAOP 
> protocol. ShairPort does not support AirPlay v2 (video and photo 
> streaming).
> 
> It supports multiple simultaneous streams, if your audio output 
> chain (as detected by libao) does so.
> 
> WWW: https://github.com/albertz/shairport
> 
> PR:             ports/163777 Submitted by:   Miks Mikelsons <miks 
> at cubesystems.lv>
> 
> Revision  Changes    Path 1.1203    +1 -0 ports/audio/Makefile 1.1
> +48 -0 ports/audio/shairport/Makefile (new) 1.1       +2 -0 
> ports/audio/shairport/distinfo (new) 1.1       +31 -0 
> ports/audio/shairport/files/shairport.in (new) 1.1       +8 -0 
> ports/audio/shairport/pkg-descr (new)

This port is really nice, thanks! I'm really enjoying streaming music
to my FreeBSD box from my iPhone. I do have a few suggestions for the
port and a question.

Since the /usr/local/bin/shairport.pl that runs it has:

use 5.10.0;
# For given() { when() { } ... }
use feature ":5.10";

at the top, perhaps USE_PERL5=5.10.0+ would be good to add to the port
Makefile.

The rc script has:

# REQUIRE: DAEMON avahi_daemon

but should probably have:

# REQUIRE: LOGIN avahi_daemon

instead.

Also, I think it may be more correct to set command_interpreter
instead of setting procname="perl". See
http://www.freebsd.org/doc/en/books/porters-handbook/rc-scripts.html
for info on both of these.

I notice that there seems to be a C port included as well. Perhaps
that could be used instead of the perl version, so that it doesn't
need perl at all?

There is no documentation installed at all. Perhaps at least
installing the README.md file would be nice?

When I went to start it up, it would startup then fail. dbus did log
this message:

dbus[2498]: [system] Failed to activate service
'org.freedesktop.Avahi': timed out

and eventually I figured out I needed to start avahi-daemon. Then I
got this in messages:

avahi-daemon[30489]: WARNING: No NSS support for mDNS detected,
consider installing nss-mdns!

Not sure if anything can be done about that one.

I guess this is a more general question about the rc script, but
should the avahi_daemon bit in the REQUIRE line trigger something
telling me that or causing the script to not start if avahi_daemon
isn't running or is it only used for ordering?

Thanks,
Steve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)

iQEcBAEBAgAGBQJPCQ+EAAoJEPXPYrMgexuhXE4IAIObXH2XBb8r+puNzGZOILoX
5u42ISaWagqX7wdMO2W9hHfetEOaa+Or8VNHgGgJPhmtmyTLwkjvlbcHCcUZHybH
9bBW6vl1vpnco1vXQO1gINJFaHtZYJ8qR6kKF2d6DsS6C6ShbGWQ8xQTyzCCqZeP
xZ04TkwQZhQhh/g7c12fjQ5yBqQc1gaVTZfbsfviiELgKc7X1Hpog7VnAj3jWQzh
n/VLmyD10GyIIoHYnwTWMsERXzCoqxSf7um0oX/+XnLJDpSGE1PMIBQWpYRgbMQf
REyrUrFTI5LM9mNHK69jWIghzIsxH76Txrj/GvecX/9aZK0sY4XVQ7Ibf7kSBu8=
=tBA4
-----END PGP SIGNATURE-----



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F090F85.8000502>