Date: Sun, 16 Sep 2012 16:24:33 +0200 From: Tijl Coosemans <tijl@coosemans.org> To: Eitan Adler <eadler@freebsd.org> Cc: Bruce Cran <bruce@cran.org.uk>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240527 - head/bin/df Message-ID: <5055E121.2030208@coosemans.org> In-Reply-To: <CAF6rxgmDckK6RE=UG8dpMDuXk_zPeUTLbC4x74XYK9cJJiYfog@mail.gmail.com> References: <201209142347.q8ENlN7N034951@svn.freebsd.org> <5054EBCB.6070105@coosemans.org> <5054F116.8090503@cran.org.uk> <CAF6rxgmDckK6RE=UG8dpMDuXk_zPeUTLbC4x74XYK9cJJiYfog@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 16-09-2012 01:27, Eitan Adler wrote: > On 15 September 2012 17:20, Bruce Cran <bruce@cran.org.uk> wrote: >> On 15/09/2012 21:57, Tijl Coosemans wrote: >>> >>> Freeing memory right before exiting is a waste of time. The tool shouldn't >>> complain about it. > > Perhaps, but tools do. This has already been brought up on cfe-dev. > >> "/Stop wasting time and just exit already/." - >> http://blogs.msdn.com/b/oldnewthing/archive/2012/01/05/10253268.aspx > > I read this blog post when it came out. :) In this case the free is actually wrong, because the pointer can point to memory allocated by getmntinfo(3) and that manpage says an application cannot free it. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iF4EAREIAAYFAlBV4SYACgkQfoCS2CCgtiumFAD+LnchYDKAQbLekIn2QPiSI6cp 1fP1DNaeX+1N5Mu+jI4A/2PDG2/qlwF+499uPoZQjXQ1DfkMFO2VYUY69V1VKU+h =0FKG -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5055E121.2030208>