Date: Mon, 16 Dec 2002 16:09:29 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: Nate Lawson <nate@root.org> Cc: Julian Elischer <julian@FreeBSD.ORG>, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 dump_machdep.c Message-ID: <200212170009.gBH09TFn082087@apollo.backplane.com> References: <Pine.BSF.4.21.0212161505500.47122-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hmm. Wouldn't this be easier if the test were done after
calculating dumplo? e.g.
:> dumplo = di->mediaoffset + di->mediasize - Maxmem * (off_t)PAGE_SIZE;
:> dumplo -= sizeof kdh * 2;
/*
* Make sure the media is big enough, and that we do not
* overwrite potential label data.
*/
if (dumplo - 64 * 1024 < di->mediaoffset) {
...
}
-Matt
Matthew Dillon
<dillon@backplane.com>
:> Don't dump core into a partition that is too small for it.
:> If we do, we usually wrote backwareds into the proceeding partititon
:> which is usually the root partition.
:> [..]
:> @@ -75,6 +75,15 @@
:> strncpy(kdh.panicstring, panicstr, sizeof kdh.panicstring);
:> kdh.parity = kerneldump_parity(&kdh);
:>
:> + if (di->mediasize <
:> + ((Maxmem * (off_t)PAGE_SIZE) + /* Memory to save */
:> + (sizeof kdh * 2) + /* header + trailer */
:> + (64*1024))) { /* Room to leave untouched */
:> + /* at partition head. */
:> + /* (an arbitrary amount). */
:> + printf("\nDump failed. Partition too small.\n");
:> + return;
:> + }
:> dumplo = di->mediaoffset + di->mediasize - Maxmem * (off_t)PAGE_SIZE;
:> dumplo -= sizeof kdh * 2;
:> i = di->dumper(di->priv, &kdh, 0, dumplo, sizeof kdh);
:
:Heh, it seems you went even farther to tweak everyone that had style(9)
:complaints with the proposal. At the very least, PLEASE move the comment
:to before the line.
:
:Functionally, it is important that this check be MI.
:
:-Nate
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200212170009.gBH09TFn082087>