Date: Mon, 29 Aug 2022 14:00:28 -0400 From: Mark Johnston <markj@freebsd.org> To: Alexander Motin <mav@freebsd.org> Cc: Matthew Grooms <mgrooms@shrew.net>, freebsd-stable@freebsd.org Subject: Re: CAM IOCTL issue with 13.1-STABLE Message-ID: <Ywz%2BvA4Ls6to3XHz@nuc> In-Reply-To: <3caeafa8-6c9c-2632-9010-9c8e21098378@FreeBSD.org> References: <c1575141-ebc2-ece1-db23-7d50e6bac6db@shrew.net> <3caeafa8-6c9c-2632-9010-9c8e21098378@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 23, 2022 at 09:44:48AM -0400, Alexander Motin wrote: > Hi Matthew, > > I took a brief look on it and found that CAM compatibility code just > does not cover that IOCTL. That is why when CAM version was bumped it > cause the unexpected breakage. Short term fix would be to rebuild the > application to new CAM version, while for proper fix somebody would have > to implement the compatibility code for that IOCTL. I looked at this a bit more, and it seems trivial since 1) for periph drivers, CAMGETPASSTHRU ignores the input CCB, and 2) the CAM version bump from 0x19 to 0x1a does not affect XPT_GDEVLIST CCBs. Note for instance that cam_compat_handle_0x19() is a no-op for CAMGETPASSTHRU. So, isn't the patch here sufficient? https://reviews.freebsd.org/D36389 > On 22.08.2022 14:48, Matthew Grooms wrote: > > There appears to be a problem with XPT_DEV_MATCH CAM IOCTL calls. This > > prevents a bunch of packages on 13.1-STABLE from working correctly. A > > bug was filed and Mark J was kind enough to help diagnose the issue, but > > it's sitting in unassigned status. Can someone please assign it to the > > correct group so it gets some attention? > > > > The FreeBSD bug: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264709 > > > > The offending commit ( I think? ): > > https://cgit.freebsd.org/src/commit/sys/cam/cam_ccb.h?h=stable/13&id=7d7168478380f08b3a7fd58ca7cf83182fae6850 > > -- > Alexander Motin >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Ywz%2BvA4Ls6to3XHz>