Date: Sun, 6 May 2018 15:44:00 +0000 From: Koichiro Iwao <meta@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Adam Weinberger <adamw@adamw.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace Message-ID: <01010163361fbfc6-24fd8a1b-0079-482d-8f4c-d7bb3a219639-000000@us-west-2.amazonses.com> In-Reply-To: <20180506151057.GA79630@FreeBSD.org> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org> <CC3C2D9C-F9B7-48DE-A53B-D9193C6CE65E@adamw.org> <20180506151057.GA79630@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 06, 2018 at 03:10:57PM +0000, Alexey Dokuchaev wrote: > On Sun, May 06, 2018 at 08:41:36AM -0600, Adam Weinberger wrote: > > Sorry, Alexey, but portlint was right here. @sample and other macros > > should *never* appear in PLIST_FILES. Even if the port installs only a > > single file, if it's a @sample, it goes in pkg-plist. > > Hmm, that's news to me; I'm pretty sure I've used @sample in PLIST_FILES, > verified generated package, and it came out as expected. I've also seen > others doing the same. Which is correct? As you say, it looks macros can be used in PLIST_FILES for me now. BTW, just let me say pkg bus error is not the reason why I switched to pkg-plist. I also thought macros shouldn't appear in PLIST_FILES when I made the commit. Thus I didn't mention about the pkg bug in the commit message at all. -- meta <meta@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01010163361fbfc6-24fd8a1b-0079-482d-8f4c-d7bb3a219639-000000>