Date: Tue, 3 Mar 1998 19:36:31 +0000 (GMT) From: Terry Lambert <tlambert@primenet.com> To: wollman@khavrinen.lcs.mit.edu (Garrett Wollman) Cc: winter@jurai.net, tlambert@primenet.com, current@FreeBSD.ORG Subject: Re: Patches in support of security Message-ID: <199803031936.MAA02971@usr02.primenet.com> In-Reply-To: <199803031815.NAA24284@khavrinen.lcs.mit.edu> from "Garrett Wollman" at Mar 3, 98 01:15:25 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> > This looks useful. (or at least is a useful first step) While some > > policies may be enforced with creative firewall rules, these patches > > provide a clean interface at the application level. > > This seems potentially acceptable. A couple of nits: > > 1) The socket option in question is clearly also applicable to UDP > sockets (and those of any other IP-based protocol). It should be an > IP-level option, not a TCP-level one. The interface will come back untrusted if there is not a route for it available. I was trying to limit it to connected sockets. You could do connected sockets in a UDP client, but interface trust is much less useful for clients than it is for servers. I would even argue it's only useful for servers. I suppose if it were bound to a particular interface insetad of INADDR_ANY, a UDP server would be able to make the decision, but it could do so by grabbing the interface flags directly. I can add this code, if you want, but I didn't see it as being useful in a datagram environment. > 2) Read style(9). This is moderately bogus, if you are complaining about parenthesis placement in the (trivial) tcp_trusted function, since it's a new function. Also, read indent(1). If you are complaining about the lack of prototypes in the declaration, style(9) explicitly allows for matching the declaration style of the compilation unit. 8-(. Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199803031936.MAA02971>