Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 21 Sep 2009 13:09:56 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r197390 - in head/sys: kern sys
Message-ID:  <200909211309.n8LD9uTE090256@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: kib
Date: Mon Sep 21 13:09:56 2009
New Revision: 197390
URL: http://svn.freebsd.org/changeset/base/197390

Log:
  Remove forward_roundrobin(), it is unused for quite some time.
  
  Reviewed by:	jhb
  MFC after:	1 week

Modified:
  head/sys/kern/subr_smp.c
  head/sys/sys/smp.h

Modified: head/sys/kern/subr_smp.c
==============================================================================
--- head/sys/kern/subr_smp.c	Mon Sep 21 09:41:51 2009	(r197389)
+++ head/sys/kern/subr_smp.c	Mon Sep 21 13:09:56 2009	(r197390)
@@ -104,12 +104,6 @@ SYSCTL_INT(_kern_smp, OID_AUTO, forward_
 	   &forward_signal_enabled, 0,
 	   "Forwarding of a signal to a process on a different CPU");
 
-/* Enable forwarding of roundrobin to all other cpus */
-static int forward_roundrobin_enabled = 1;
-SYSCTL_INT(_kern_smp, OID_AUTO, forward_roundrobin_enabled, CTLFLAG_RW,
-	   &forward_roundrobin_enabled, 0,
-	   "Forwarding of roundrobin to all other CPUs");
-
 /* Variables needed for SMP rendezvous. */
 static volatile int smp_rv_ncpus;
 static void (*volatile smp_rv_setup_func)(void *arg);
@@ -189,33 +183,6 @@ forward_signal(struct thread *td)
 	ipi_selected(1 << id, IPI_AST);
 }
 
-void
-forward_roundrobin(void)
-{
-	struct pcpu *pc;
-	struct thread *td;
-	cpumask_t id, map, me;
-
-	CTR0(KTR_SMP, "forward_roundrobin()");
-
-	if (!smp_started || cold || panicstr)
-		return;
-	if (!forward_roundrobin_enabled)
-		return;
-	map = 0;
-	me = PCPU_GET(cpumask);
-	SLIST_FOREACH(pc, &cpuhead, pc_allcpu) {
-		td = pc->pc_curthread;
-		id = pc->pc_cpumask;
-		if (id != me && (id & stopped_cpus) == 0 &&
-		    !TD_IS_IDLETHREAD(td)) {
-			td->td_flags |= TDF_NEEDRESCHED;
-			map |= id;
-		}
-	}
-	ipi_selected(map, IPI_AST);
-}
-
 /*
  * When called the executing CPU will send an IPI to all other CPUs
  *  requesting that they halt execution.

Modified: head/sys/sys/smp.h
==============================================================================
--- head/sys/sys/smp.h	Mon Sep 21 09:41:51 2009	(r197389)
+++ head/sys/sys/smp.h	Mon Sep 21 13:09:56 2009	(r197390)
@@ -120,7 +120,6 @@ void	cpu_mp_setmaxid(void);
 void	cpu_mp_start(void);
 
 void	forward_signal(struct thread *);
-void	forward_roundrobin(void);
 int	restart_cpus(cpumask_t);
 int	stop_cpus(cpumask_t);
 int	stop_cpus_hard(cpumask_t);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200909211309.n8LD9uTE090256>