Date: Fri, 21 Sep 2018 18:06:39 -0400 From: Mark Johnston <markj@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: Mark Millard <marklmi@yahoo.com>, FreeBSD Toolchain <freebsd-toolchain@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: building head -r338675 with devel/amd64-gcc: /usr/local/x86_64-unknown-freebsd12.0/bin/ld: warning: -z ifunc-noplt ignored Message-ID: <20180921220639.GF5120@raichu> In-Reply-To: <CAPyFy2DTw-LGXUVCP2W0MOW0bXWe2An18Y-Uy-U6X40UJCiy6w@mail.gmail.com> References: <2E7136DD-9C25-44C1-8C9A-310C2D1D7189@yahoo.com> <CAPyFy2BHUocGh-H8xfmdQXTTX_Qvoi50xKzoTGco8Cn9FfGcyQ@mail.gmail.com> <20180921193139.GB5120@raichu> <CAPyFy2DTw-LGXUVCP2W0MOW0bXWe2An18Y-Uy-U6X40UJCiy6w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 21, 2018 at 04:37:08PM -0400, Ed Maste wrote:
> On 21 September 2018 at 15:31, Mark Johnston <markj@freebsd.org> wrote:
> >
> > Perhaps the following? It's not quite right since it'll still use
> > -zifunc-noplt with an external LLVM toolchain, but I can't seem to
> > figure out how to define a linker feature for only non-cross toolchains.
> > In any case, we're going to upstream the option soon.
>
> I wouldn't worry too much about out-of-tree since it will be upstream
> soon as you say, otherwise looks good.
>
> > +.if ${MACHINE_CPUARCH} == "amd64" || ${MACHINE_CPUARCH} == "i386"
> > +.if defined(LINKER_FEATURES) && ${LINKER_FEATURES:Mifunc} == ""
> > .error amd64/i386 kernel requires linker ifunc support
> > .endif
> > +.if defined(LINKER_FEATURES) && ${LINKER_FEATURES:Mifunc-noplt} != ""
>
> Maybe roll && defined(LINKER_FEATURES) into the outer .if?
https://reviews.freebsd.org/D17279 for anyone else that would like to
review.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180921220639.GF5120>